[snmp] Set thing only online on valid response #8759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured). Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Travis tests were successfulHey @Hilbrand, |
J-N-K
approved these changes
Oct 15, 2020
|
Look like you need to fix the tests |
The status is now set ONLINE only when a succesful response is received. Adapted unit tests to check for it after response is processed. Refactored deprecated initMocks to openMocks. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
|
Doh! I was so focused on not forgetting to run spotless that I completely forgot to run a install 🤦 |
J-N-K
approved these changes
Oct 25, 2020
boehan
pushed a commit
to boehan/openhab-addons
that referenced
this pull request
Apr 12, 2021
* [snmp] Set thing only online on valid response Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured). Signed-off-by: Hilbrand Bouwkamp <[email protected]>
marcfischerboschio
pushed a commit
to bosch-io/openhab-addons
that referenced
this pull request
May 5, 2022
* [snmp] Set thing only online on valid response Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured). Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise it will toggles between online and offline when the call always times-out, which can happen when the device is unreachable (or a wrong ip address configured).