Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[somfytahoma] improved discovery service registration #8439

Merged
merged 1 commit into from
Sep 10, 2020
Merged

[somfytahoma] improved discovery service registration #8439

merged 1 commit into from
Sep 10, 2020

Conversation

octa22
Copy link
Contributor

@octa22 octa22 commented Sep 9, 2020

this PR improves and simplyfies the discovery service registration

@TravisBuddy
Copy link

Travis tests were successful

Hey @octa22,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand approved these changes Sep 9, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 32c3cb9 into openhab:2.5.x Sep 10, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 10, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@octa22 @CSchlipp
[somfytahoma] improved discovery service registration (openhab#8439)
9959efc 
Signed-off-by: Ondrej Pecta <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@octa22 @markus7017
[somfytahoma] improved discovery service registration (openhab#8439)
e245707 
Signed-off-by: Ondrej Pecta <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@octa22 @andrewfg
[somfytahoma] improved discovery service registration (openhab#8439)
502c9e1 
Signed-off-by: Ondrej Pecta <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
3 participants
@octa22 @TravisBuddy @Hilbrand