Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nikohomecontrol] Check bridge status when thing ready to go online. #8428

Merged
merged 2 commits into from
Sep 8, 2020

Conversation

mherwege
Copy link
Contributor

@mherwege mherwege commented Sep 7, 2020

Signed-off-by: Mark Herwege [email protected]

I had a report of a badly configured thing going online when the bridge went online, thereafter leading to a NPE on refresh. This should prevent this from happening.

@mherwege mherwege added the bug An unexpected problem or unintended behavior of an add-on label Sep 7, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @mherwege,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @mherwege,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit c42baca into openhab:2.5.x Sep 8, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Sep 8, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants