Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[onkyo] Add support for TX-RZ900 #8410

Merged
merged 1 commit into from
Sep 6, 2020
Merged

[onkyo] Add support for TX-RZ900 #8410

merged 1 commit into from
Sep 6, 2020

Conversation

Cossey
Copy link
Contributor

@Cossey Cossey commented Sep 6, 2020

As per request in #8245

@Cossey Cossey added the enhancement An enhancement or new feature for an existing add-on label Sep 6, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @Cossey,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Cossey Cossey linked an issue Sep 6, 2020 that may be closed by this pull request
[Onkyo] Please add the TX-RZ900 to the list of supported devices #8245
Closed
wborn
wborn approved these changes Sep 6, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pail23
Copy link
Contributor

pail23 commented Sep 6, 2020

LGTM

@wborn wborn merged commit 4d696df into openhab:2.5.x Sep 6, 2020
@wborn wborn added this to the 2.5.9 milestone Sep 6, 2020
@Cossey Cossey deleted the Onkyo-Add-TXRZ900 branch September 7, 2020 07:37
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Cossey @CSchlipp
Add support for TX-RZ900 as per request in openhab#8245 (openhab#8410)
cc688d0 
Signed-off-by: Stewart Cossey <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Cossey @markus7017
Add support for TX-RZ900 as per request in openhab#8245 (openhab#8410)
115702e 
Signed-off-by: Stewart Cossey <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@Cossey @andrewfg
Add support for TX-RZ900 as per request in openhab#8245 (openhab#8410)
2b4f699 
Signed-off-by: Stewart Cossey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@pail23 pail23 pail23 approved these changes

@paulianttila paulianttila Awaiting requested review from paulianttila paulianttila is a code owner

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.

[Onkyo] Please add the TX-RZ900 to the list of supported devices
4 participants
@Cossey @TravisBuddy @pail23 @wborn