-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dsmr] Handle cosem values that a have a unit or not, related to smarty meters #8383
Conversation
Travis tests were successfulHey @Hilbrand, |
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Signed-off-by: Hilbrand Bouwkamp <[email protected]>
The telegram files have a checksum that includes the newlines. So it's important the specific newline endings always remain the same. The protocol uses windows line endings, therefor fixed to windows line endings. It was previously set to binary, but that makes it difficult to textual compare with git as it doesn't compare binary files. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
It appears some Luxembourg meters have a unit in the cosem value, while other meters don't report this value. This changes makes it possible to handle both cases. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Travis tests were successfulHey @Hilbrand, |
This PR seems to have broken the build now that Spotless is enabled:
|
PR openhab#8383 was created before Spotless was enforced. Signed-off-by: Wouter Born <[email protected]>
It was to be expected so I'll trigger some builds on recent PRs to reduce the chance of it happening again. 😉 |
PR #8383 was created before Spotless was enforced. Signed-off-by: Wouter Born <[email protected]>
…ty meters (openhab#8383) * [dsmr] Smarty fix for decrypting different length Initialization Vector * [dsmr] Changed specific gitattributes to eol The telegram files have a checksum that includes the newlines. So it's important the specific newline endings always remain the same. The protocol uses windows line endings, therefor fixed to windows line endings. It was previously set to binary, but that makes it difficult to textual compare with git as it doesn't compare binary files. * [dsmr] Handle specific cosem values that can either have a unit or not It appears some Luxembourg meters have a unit in the cosem value, while other meters don't report this value. This changes makes it possible to handle both cases. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
PR openhab#8383 was created before Spotless was enforced. Signed-off-by: Wouter Born <[email protected]>
…ty meters (openhab#8383) * [dsmr] Smarty fix for decrypting different length Initialization Vector * [dsmr] Changed specific gitattributes to eol The telegram files have a checksum that includes the newlines. So it's important the specific newline endings always remain the same. The protocol uses windows line endings, therefor fixed to windows line endings. It was previously set to binary, but that makes it difficult to textual compare with git as it doesn't compare binary files. * [dsmr] Handle specific cosem values that can either have a unit or not It appears some Luxembourg meters have a unit in the cosem value, while other meters don't report this value. This changes makes it possible to handle both cases. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
PR openhab#8383 was created before Spotless was enforced. Signed-off-by: Wouter Born <[email protected]>
…ty meters (openhab#8383) * [dsmr] Smarty fix for decrypting different length Initialization Vector * [dsmr] Changed specific gitattributes to eol The telegram files have a checksum that includes the newlines. So it's important the specific newline endings always remain the same. The protocol uses windows line endings, therefor fixed to windows line endings. It was previously set to binary, but that makes it difficult to textual compare with git as it doesn't compare binary files. * [dsmr] Handle specific cosem values that can either have a unit or not It appears some Luxembourg meters have a unit in the cosem value, while other meters don't report this value. This changes makes it possible to handle both cases. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
PR openhab#8383 was created before Spotless was enforced. Signed-off-by: Wouter Born <[email protected]>
And some minor cleanup fixes.