Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Start watchservice message with path #8380

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

marcelrv
Copy link
Contributor

@marcelrv marcelrv commented Sep 1, 2020

Provide a message with path to facilitate users to find the right path
to store the json db files (avoiding many questions on the community)

Signed-off-by: Marcel Verpaalen [email protected]

Provide a message with path to facilitate users to find the right path
to store the json db files (avoiding many questions on the community)

Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv requested a review from cpmeister September 1, 2020 18:10
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@fwolter fwolter merged commit 2596ad0 into openhab:2.5.x Sep 1, 2020
@fwolter fwolter added this to the 2.5.9 milestone Sep 1, 2020
@marcelrv marcelrv deleted the miio-watchservice-message branch September 2, 2020 07:02
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
Provide a message with path to facilitate users to find the right path
to store the json db files (avoiding many questions on the community)

Signed-off-by: Marcel Verpaalen <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Provide a message with path to facilitate users to find the right path
to store the json db files (avoiding many questions on the community)

Signed-off-by: Marcel Verpaalen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
Provide a message with path to facilitate users to find the right path
to store the json db files (avoiding many questions on the community)

Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants