Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus] Off-by-one fixes for data thing read index validation #8301

Merged
merged 1 commit into from
Aug 15, 2020

Conversation

ssalonen
Copy link
Contributor

@ssalonen ssalonen commented Aug 15, 2020

Fixes #8300

Signed-off-by: Sami Salonen [email protected]

@ssalonen ssalonen requested a review from a team as a code owner August 15, 2020 17:10
@ssalonen ssalonen force-pushed the modbus-config-fixes branch from ec98bb0 to 7c5eaf4 Compare August 15, 2020 17:10
@TravisBuddy
Copy link

Travis tests were successful

Hey @ssalonen,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @ssalonen,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@fwolter fwolter added the bug An unexpected problem or unintended behavior of an add-on label Aug 15, 2020
@fwolter fwolter merged commit 2dd2ab5 into openhab:2.5.x Aug 15, 2020
@fwolter fwolter added this to the 2.5.8 milestone Aug 15, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[modbus] data thing configuration validation misleading and too relaxed
3 participants