-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[modbus] Fix for #8298: Avoid NPE on serial I/O error #8299
Conversation
Signed-off-by: Wolfgang Klimt <[email protected]>
Travis tests were successfulHey @Wolfgang1966, |
Hey @Wolfgang1966, TravisCI finished with status TravisBuddy Request Identifier: 0ce786a0-dedd-11ea-a02c-4f626b4af334 |
Hey @Wolfgang1966, TravisCI finished with status TravisBuddy Request Identifier: 27c60910-dedd-11ea-a02c-4f626b4af334 |
Travis tests were successfulHey @Wolfgang1966, |
I somehow messed up the signoff. Do I have to open a new PR to get this sorted out? |
…into 2.5.x Signed-off-by: Wolfgang Klimt <[email protected]>
Travis tests were successfulHey @Wolfgang1966, |
Signed-off-by: Wolfgang Klimt <[email protected]>
Travis tests were successfulHey @Wolfgang1966, |
1 similar comment
Travis tests were successfulHey @Wolfgang1966, |
@Wolfgang1966 I believe the issue is fixed already in #8206? For what it's worth, the PR explains the root cause |
Hi @ssalonen , yes, you are right. I close this PR. Sorry, I could have checked the existing modbus PRs first. Have a nice weekend! Wolfgang |
For some reason I did not analyze in detail,
endpoint
is null in my case whenmaybeResetConnection
is called. As an I/O error was preceding the call, resetting the connection seems to be a good way of dealing with the situation. At least it fixes the problem in my setup.Find patched jars here:
https://home.klimt.de/owncloud/index.php/s/7zbBpJWKPSYBrPH