Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus] Fix for #8298: Avoid NPE on serial I/O error #8299

Closed
wants to merge 5 commits into from
Closed

[modbus] Fix for #8298: Avoid NPE on serial I/O error #8299

wants to merge 5 commits into from

Conversation

Wolfgang1966
Copy link

For some reason I did not analyze in detail, endpoint is null in my case when maybeResetConnection is called. As an I/O error was preceding the call, resetting the connection seems to be a good way of dealing with the situation. At least it fixes the problem in my setup.

Find patched jars here:

https://home.klimt.de/owncloud/index.php/s/7zbBpJWKPSYBrPH

@Wolfgang1966 Wolfgang1966 requested a review from ssalonen as a code owner August 15, 2020 09:28
@TravisBuddy
Copy link

Travis tests were successful

Hey @Wolfgang1966,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Hey @Wolfgang1966,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 0ce786a0-dedd-11ea-a02c-4f626b4af334

@TravisBuddy
Copy link

Hey @Wolfgang1966,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 27c60910-dedd-11ea-a02c-4f626b4af334

@TravisBuddy
Copy link

Travis tests were successful

Hey @Wolfgang1966,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Wolfgang1966 Wolfgang1966 reopened this Aug 15, 2020
@Wolfgang1966
Copy link
Author

I somehow messed up the signoff. Do I have to open a new PR to get this sorted out?

@TravisBuddy
Copy link

Travis tests were successful

Hey @Wolfgang1966,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @Wolfgang1966,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @Wolfgang1966,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@ssalonen
Copy link
Contributor

ssalonen commented Aug 15, 2020

@Wolfgang1966 I believe the issue is fixed already in #8206?

For what it's worth, the PR explains the root cause

@Wolfgang1966
Copy link
Author

Hi @ssalonen , yes, you are right. I close this PR.

Sorry, I could have checked the existing modbus PRs first.

Have a nice weekend!

Wolfgang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants