Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lcn] Remove status-only Channels from LCN Group Thing #8286

Merged
merged 1 commit into from
Aug 27, 2020
Merged

[lcn] Remove status-only Channels from LCN Group Thing #8286

merged 1 commit into from
Aug 27, 2020

Conversation

fwolter
Copy link
Member

@fwolter fwolter commented Aug 13, 2020

As LCN groups don't send any status messages, it makes no sense to have status Channels for LCN groups. They will never be updated.

Signed-off-by: Fabian Wolter [email protected]

As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @fwolter,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Hilbrand Hilbrand added the enhancement An enhancement or new feature for an existing add-on label Aug 27, 2020
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 33442c2 into openhab:2.5.x Aug 27, 2020
@Hilbrand Hilbrand added this to the 2.5.9 milestone Aug 27, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
@fwolter fwolter deleted the lcn-remove-trigger branch September 14, 2020 18:29
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
As LCN groups don't send any status messages, it makes no sense to have the same Channels as an LCN module.

Signed-off-by: Fabian Wolter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants