Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lcn] Add support for commands from LCN to openHAB #8284

Merged
merged 3 commits into from
Aug 31, 2020
Merged

[lcn] Add support for commands from LCN to openHAB #8284

merged 3 commits into from
Aug 31, 2020

Conversation

fwolter
Copy link
Member

@fwolter fwolter commented Aug 13, 2020

Signed-off-by: Fabian Wolter [email protected]

@TravisBuddy
Copy link

Travis tests were successful

Hey @fwolter,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@fwolter fwolter added the enhancement An enhancement or new feature for an existing add-on label Aug 13, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @fwolter,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Hilbrand Hilbrand requested a review from cpmeister August 29, 2020 13:16
@fwolter fwolter requested a review from Hilbrand August 30, 2020 18:22
@TravisBuddy
Copy link

Travis tests were successful

Hey @fwolter,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cpmeister
cpmeister approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit f383bcb into openhab:2.5.x Aug 31, 2020
@cpmeister cpmeister added this to the 2.5.9 milestone Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@fwolter @DaanMeijer
[lcn] Add support for commands from LCN to openHAB (openhab#8284)
ee1059e 
* [lcn] Add support for commands from LCN to openHAB
* Add options tag for sendKeys Channel
* Add ID to enum and change field name

Signed-off-by: Fabian Wolter <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@fwolter @CSchlipp
[lcn] Add support for commands from LCN to openHAB (openhab#8284)
a4ef28f 
* [lcn] Add support for commands from LCN to openHAB
* Add options tag for sendKeys Channel
* Add ID to enum and change field name

Signed-off-by: Fabian Wolter <[email protected]>
@fwolter fwolter deleted the lcn-sendkey branch September 14, 2020 18:28
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@fwolter @markus7017
[lcn] Add support for commands from LCN to openHAB (openhab#8284)
7699600 
* [lcn] Add support for commands from LCN to openHAB
* Add options tag for sendKeys Channel
* Add ID to enum and change field name

Signed-off-by: Fabian Wolter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Oct 8, 2020
@fwolter @andrewfg
[lcn] Add support for commands from LCN to openHAB (openhab#8284)
800e4de 
* [lcn] Add support for commands from LCN to openHAB
* Add options tag for sendKeys Channel
* Add ID to enum and change field name

Signed-off-by: Fabian Wolter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.9
Development

Successfully merging this pull request may close these issues.
4 participants
@fwolter @TravisBuddy @cpmeister @Hilbrand