Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) #8283

Merged
merged 3 commits into from
Aug 17, 2020
Merged

[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) #8283

merged 3 commits into from
Aug 17, 2020

Conversation

marcelrv
Copy link
Contributor

Adding Xiaomi Mijia Smart Tower Fan

  • dmaker.fan.p5
  • dmaker.fan.p9 (miot)
  • dmaker.fan.p10 (miot)

Signed-off-by: Marcel Verpaalen [email protected]

@marcelrv
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)
9dd58a7 
Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)


Signed-off-by: Marcel Verpaalen <[email protected]>
@marcelrv marcelrv added the enhancement An enhancement or new feature for an existing add-on label Aug 12, 2020
@marcelrv marcelrv requested review from cpmeister and fwolter August 12, 2020 19:05
@marcelrv marcelrv self-assigned this Aug 12, 2020
@marcelrv
Copy link
Contributor Author

related topic https://community.openhab.org/t/xiaomi-mijia-smart-tower-fan/103328

@TravisBuddy
Copy link

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@marcelrv
[miio] add dmaker.fan.p8 device
5879af0 
Signed-off-by: Marcel Verpaalen <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @marcelrv,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@marcelrv
Copy link
Contributor Author

@cpmeister @fwolter any concerns for merging this.. No code changes, just adding few new devices through db config files

kaikreuzer
kaikreuzer approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, should be good to merge. Thanks @marcelrv!

@kaikreuzer kaikreuzer added this to the 2.5.8 milestone Aug 17, 2020
@kaikreuzer kaikreuzer merged commit 88a92f8 into openhab:2.5.x Aug 17, 2020
@marcelrv marcelrv deleted the miio-dmaker-fan9 branch August 18, 2020 07:19
taboneclayton pushed a commit to taboneclayton/openhab-addons that referenced this pull request Aug 23, 2020
@marcelrv @taboneclayton
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
a307e05 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Clayton Tabone <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
a3decee 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
97dc19e 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
a551615 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@marcelrv @andrewfg
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
389b5db 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@marcelrv @DaanMeijer
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
1116bfe 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@marcelrv @CSchlipp
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
0ee0bee 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@marcelrv @markus7017
[miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan) (openhab#8283)
a762906 
* [miio] add Xiaomi Mijia Smart Tower Fan (dmaker.fan)

Adding Xiaomi Mijia Smart Tower Fan
* dmaker.fan.p5
* dmaker.fan.p8
* dmaker.fan.p9 (miot)
* dmaker.fan.p10 (miot)
* dmaker.fan.1c & various vacuums

Signed-off-by: Marcel Verpaalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaikreuzer kaikreuzer kaikreuzer approved these changes

@cpmeister cpmeister Awaiting requested review from cpmeister

@fwolter fwolter Awaiting requested review from fwolter

Assignees

@marcelrv marcelrv

Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.
3 participants
@marcelrv @TravisBuddy @kaikreuzer