Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lametrictime] ignore javax.activation as it is not required #8272

Merged
merged 1 commit into from
Aug 9, 2020
Merged

[lametrictime] ignore javax.activation as it is not required #8272

merged 1 commit into from
Aug 9, 2020

Conversation

kaikreuzer
Copy link
Member

@kaikreuzer kaikreuzer requested a review from syphr42 as a code owner August 9, 2020 14:09
@kaikreuzer kaikreuzer mentioned this pull request Aug 9, 2020
Merged
@TravisBuddy
Copy link

Travis tests were successful

Hey @kaikreuzer,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@kaikreuzer kaikreuzer requested review from wborn and removed request for syphr42 August 9, 2020 14:21
kaikreuzer
kaikreuzer commented Aug 9, 2020
View reviewed changes
Copy link
Member Author

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please allow me to self-merge as I need the addons-port build working...

@kaikreuzer kaikreuzer merged commit cbbdce6 into openhab:2.5.x Aug 9, 2020
@kaikreuzer kaikreuzer deleted the lametricactivation branch August 9, 2020 14:42
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@kaikreuzer @andrewfg
ignore javax.activation as it is not required (openhab#8272)
442cb4a 
Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@kaikreuzer @andrewfg
ignore javax.activation as it is not required (openhab#8272)
474441d 
Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@kaikreuzer @andrewfg
ignore javax.activation as it is not required (openhab#8272)
96301db 
Signed-off-by: Kai Kreuzer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@kaikreuzer @andrewfg
ignore javax.activation as it is not required (openhab#8272)
70069c5 
Signed-off-by: Kai Kreuzer <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@kaikreuzer @DaanMeijer
ignore javax.activation as it is not required (openhab#8272)
53ef1fd 
Signed-off-by: Kai Kreuzer <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@kaikreuzer @CSchlipp
ignore javax.activation as it is not required (openhab#8272)
1f8cf3a 
Signed-off-by: Kai Kreuzer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@kaikreuzer @markus7017
ignore javax.activation as it is not required (openhab#8272)
4c319d9 
Signed-off-by: Kai Kreuzer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn Awaiting requested review from wborn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaikreuzer @TravisBuddy