[rfxcom] Thread naming #8235
Merged
[rfxcom] Thread naming #8235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
Travis tests were successfulHey @lolodomo, |
fwolter
approved these changes
Aug 1, 2020
Hilbrand
reviewed
Aug 1, 2020
| @@ -242,4 +242,6 @@ | |||
| put(PacketType.WIND, RFXComBindingConstants.THING_TYPE_WIND); | |||
| } | |||
| }); | |||
|
|
|||
| public static final String THREAD_NAME_PREFIX = "OH-" + BINDING_ID + "-"; | |||
There was a problem hiding this comment.
The binding id is already in in the thing uid. Therefor make it OH-binding- that will make it easier to find all binding specific threads.
There was a problem hiding this comment.
Ok, I am going to change that.
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Related to openhab#8216 Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #8216
Signed-off-by: Laurent Garnier [email protected]