[modbus] Correct exception type in implementation. #8218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
Travis tests have failedHey @ssalonen, |
Signed-off-by: Sami Salonen <[email protected]>
Travis tests were successfulHey @ssalonen, |
fwolter
approved these changes
Jul 28, 2020
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Interface remains the same. Signed-off-by: Sami Salonen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation was raising
IllegalStateExceptionwhileinterfacewas throwingEndpointNotInitializedException.This is issue in theory -- all consumers check corresponding thing status first (e.g. in initialize), and only call the method, thus the endpoint is always initialized.
No changes to interface -> no changes to bindings relying on the API.
Signed-off-by: Sami Salonen [email protected]