-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amazonechocontrol] improve login handling #8207
Conversation
Signed-off-by: Jan N. Klug <[email protected]>
Travis tests were successfulHey @J-N-K, |
Sorry, I have not seen your PR. I did the same here: #8211 As far as I see, it is very similar, the difference are that my check device id function does not thrown and catch an exception and that I did the regeneration of the device id only in the case if the login page is requested. In my opinion, this is more safe because if a token was not rejected by the amazon server, the connection keeps working. |
...azonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java
Outdated
Show resolved
Hide resolved
...azonechocontrol/src/main/java/org/openhab/binding/amazonechocontrol/internal/Connection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jan N. Klug <[email protected]>
@mgeramb I included your comments and did some more clarification on the device-id generation |
Travis tests were successfulHey @J-N-K, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: MPH80 <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
An issue has been found where the login to the amazon account fails. Device-ids generated by bindings-versions before #8139 may have problems to login if they do not conform to the specification. The binding was not properly detecting this and further logins re-used the device-id which failed again.
This PR adds a check for the correct format of the device-id and also adds a console command to fore renewal of all connection settings.
Signed-off-by: Jan N. Klug [email protected]