Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] Support for Welcome camera event categories #8203

Merged
merged 23 commits into from
Jul 29, 2020
Merged

[netatmo] Support for Welcome camera event categories #8203

merged 23 commits into from
Jul 29, 2020

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Jul 26, 2020

See issue #8202 for more information.

Novanic and others added 18 commits June 10, 2020 19:50
@Novanic
Merge pull request #1 from openhab/2.5.x
78699f9 
Update
@Novanic
Merge pull request #2 from openhab/2.5.x
ae6b891 
Update
@Novanic
Merge pull request #3 from openhab/2.5.x
66abc11 
Update
@Novanic
Merge pull request #4 from openhab/2.5.x
4f2cd51 
Update
@Novanic
Merge pull request #5 from openhab/2.5.x
bd9cfc1 
Update
@Novanic
Merge pull request #6 from openhab/2.5.x
de62002 
Update
@Novanic
Merge pull request #7 from openhab/2.5.x
ad272b7 
Update
@Novanic
Merge pull request #8 from openhab/2.5.x
76c47b8 
Update
@Novanic
Merge pull request #9 from openhab/2.5.x
2ce668b 
Update
@Novanic
Merge pull request #10 from openhab/2.5.x
bcfbee2 
Update
@Novanic
Merge pull request #11 from openhab/2.5.x
2d654b9 
Update
@sstrohschein
Tests added
d494fac 
Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Bug-fix: A detected person was reported as a human AND as a movement.…
c309e9e 
… It is sufficient to report it as a human, to additionally report a generic movement isn't required.

Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Support for Welcome camera event categories (the Welcome indoor camer…
b234651 
…a can now also detect animals and humans)

Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Tests added
2484e18 
Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Test code optimized
7bd1be8 
Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Code optimization
793d810 
Signed-off-by: Sven Strohschein <[email protected]>
@sstrohschein
Code optimization
027e687 
Signed-off-by: Sven Strohschein <[email protected]>
@Novanic Novanic mentioned this pull request Jul 26, 2020
Closed
@sstrohschein
Test code optimized
ff874d7 
Signed-off-by: Sven Strohschein <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@sstrohschein
Spotless applied
4ae43e3 
Signed-off-by: Sven Strohschein <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@fwolter fwolter merged commit a9ef2fd into openhab:2.5.x Jul 29, 2020
@fwolter fwolter added this to the 2.5.8 milestone Jul 29, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Novanic @MPH80
[netatmo] Support for Welcome camera event categories (openhab#8203)
ca0f7db 
Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] Support for Welcome camera event categories (openhab#8203)
5ea3c57 
Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] Support for Welcome camera event categories (openhab#8203)
3d02aae 
Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] Support for Welcome camera event categories (openhab#8203)
d58c52e 
Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] Support for Welcome camera event categories (openhab#8203)
e527c18 
Signed-off-by: Sven Strohschein <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Novanic @DaanMeijer
[netatmo] Support for Welcome camera event categories (openhab#8203)
8fd3b0c 
Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@Novanic @CSchlipp
[netatmo] Support for Welcome camera event categories (openhab#8203)
a5341d9 
Signed-off-by: Sven Strohschein <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Novanic @markus7017
[netatmo] Support for Welcome camera event categories (openhab#8203)
89b5d40 
Signed-off-by: Sven Strohschein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clinique clinique clinique requested changes

@fwolter fwolter fwolter approved these changes

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.
5 participants
@Novanic @TravisBuddy @fwolter @clinique @sstrohschein