[phc] Fix duplicate id in JRM channel definition #8191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonas Hohaus <[email protected]>
Travis tests were successfulHey @gnlpfjh, |
Hilbrand
approved these changes
Jul 27, 2020
| @@ -94,25 +88,25 @@ | |||
| <parameter name="upDownTime1" type="integer" min="1" max="65535"> | |||
| <advanced>true</advanced> | |||
| <label>Time Shutter 1</label> | |||
| <description>The Time which the first shutter needs to move up/down.</description> | |||
| <description>The time (in seconds) which the first shutter needs to move up/down.</description> | |||
There was a problem hiding this comment.
You can add the attribute unit="s" to the `parameter element to specify this is in seconds. Then it's not needed to add the unit in the description. But you can change that in some future improvement.
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Sep 12, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
Fixes a bug in the thing type definition, that has crept in openhab#6447. Signed-off-by: Jonas Hohaus <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug in the thing type definition, that has crept in #6447.
While I removed the channel groups for JRM and DIM thing types I forgot that goup id is used in the Binding.
Aditionally I didn't change the channel ids so we have duplicate ids in the JRM type definition.
So we have to use the channel-groups for all thing-types again.
The bug was found in this thread: https://community.openhab.org/t/switch-from-peha-phc-to-new-automation-with-openhab2/61154/36
Signed-off-by: Jonas Hohaus [email protected]