Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[telegram] Added support for long polling #8180

Merged
merged 1 commit into from
Jul 29, 2020
Merged

[telegram] Added support for long polling #8180

merged 1 commit into from
Jul 29, 2020

Conversation

EvilPingu
Copy link
Contributor

@EvilPingu EvilPingu commented Jul 23, 2020 •
edited
Loading

This PL closes #7043

I added a new parameter for long polling. There is a new parameter with default value 25 seconds. The Telegram WebApp uses 25 seconds. Maximal value is 50 seconds. After this time the telegram api interups the connection.

Additional i fixed some warnings.

@EvilPingu EvilPingu marked this pull request as ready for review July 23, 2020 18:29
@EvilPingu EvilPingu requested a review from ZzetT as a code owner July 23, 2020 18:29
@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@EvilPingu EvilPingu changed the title Develop [telegram] Added support for long polling Jul 23, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

2 similar comments
@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

ZzetT
ZzetT approved these changes Jul 28, 2020
View reviewed changes
Copy link

@ZzetT ZzetT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review done

@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@EvilPingu
add long polling
f7d8587 
Signed-off-by: Christian Kittel <[email protected]>
@EvilPingu
Copy link
Contributor Author

Sorry. I failed rebasing my branch. Now it's correct.

@TravisBuddy
Copy link

Travis tests were successful

Hey @EvilPingu,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand approved these changes Jul 29, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 95a47fa into openhab:2.5.x Jul 29, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 30, 2020
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@EvilPingu @MPH80
[telegram] Added support for long polling (openhab#8180)
02b9553 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@EvilPingu @andrewfg
[telegram] Added support for long polling (openhab#8180)
ed8569d 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@EvilPingu @andrewfg
[telegram] Added support for long polling (openhab#8180)
d646722 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@EvilPingu @andrewfg
[telegram] Added support for long polling (openhab#8180)
6aad687 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@EvilPingu @andrewfg
[telegram] Added support for long polling (openhab#8180)
2e749d2 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@EvilPingu @DaanMeijer
[telegram] Added support for long polling (openhab#8180)
f62c153 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@EvilPingu @CSchlipp
[telegram] Added support for long polling (openhab#8180)
e74f374 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@EvilPingu @markus7017
[telegram] Added support for long polling (openhab#8180)
4b8ca3f 
Closes openhab#7043
Signed-off-by: Christian Kittel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@ZzetT ZzetT ZzetT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.

[telegram] Telegram binding does not use Long Polling
4 participants
@EvilPingu @TravisBuddy @Hilbrand @ZzetT