Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mail] documentation enhancement. #8177

Merged
merged 3 commits into from
Jul 29, 2020
Merged

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Jul 23, 2020

Answering issue #7937

Signed-off-by: clinique [email protected]

@clinique clinique requested a review from J-N-K as a code owner July 23, 2020 14:50
Signed-off-by: clinique <[email protected]>
@openhab openhab deleted a comment from TravisBuddy Jul 23, 2020
Signed-off-by: clinique <[email protected]>
@openhab openhab deleted a comment from TravisBuddy Jul 24, 2020
@clinique clinique requested review from J-N-K and lolodomo July 24, 2020 07:41
@TravisBuddy
Copy link

Travis tests were successful

Hey @clinique,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Did you check that success value is really true?

@clinique
Copy link
Contributor Author

LGTM

Did you check that success value is really true?

I did not, just completed documentation toward the issue. If it's not true, we have a bug...

Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit 975d902 into openhab:2.5.x Jul 29, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 29, 2020
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Gaël L'hopital <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@clinique clinique deleted the Issue_7937 branch September 16, 2020 09:54
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants