Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lutron] Add system state variable support for HomeWorks QS #8132

Merged
merged 1 commit into from
Jul 28, 2020
Merged

[lutron] Add system state variable support for HomeWorks QS #8132

merged 1 commit into from
Jul 28, 2020

Conversation

bobadair
Copy link
Member

This PR adds support for HomeWorks QS system state variables.

From the updated README file:

HomeWorks QS systems allow for conditional programming logic based on state variables. The sysvar thing allows state variable values to be read and set from openHAB. This makes sophisticated integration schemes possible.

Each sysvar thing represents one system state variable. It has a single channel varstate with type Number and category Number. Automatic discovery of state variables is not yet supported. They must be manually configured.

Signed-off-by: Bob Adair [email protected]

@bobadair bobadair added the enhancement An enhancement or new feature for an existing add-on label Jul 15, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @bobadair,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@bobadair bobadair requested a review from a team July 19, 2020 16:26
Hilbrand
Hilbrand approved these changes Jul 27, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand added the rebuild Triggers Jenkins PR build label Jul 27, 2020
@TravisBuddy
Copy link

Travis tests have failed

Hey @bobadair,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@bobadair
Copy link
Member Author

Thanks @Hilbrand. I just did a rebase on 2.5.x and force push because this was originally submitted before the version change to 2.5.8-SNAPSHOT.

@Hilbrand Hilbrand removed the rebuild Triggers Jenkins PR build label Jul 28, 2020
@Hilbrand
Copy link
Member

Seems like the merge of the other pr introduced conflicts.

@bobadair
[lutron] Add sysvar handler for HomeWorks QS
fe2631d 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
@TravisBuddy
Copy link

Travis tests have failed

Hey @bobadair,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

@bobadair
Copy link
Member Author

Thanks again @Hilbrand. That merge conflict should be fixed now.

Hilbrand
Hilbrand approved these changes Jul 28, 2020
View reviewed changes
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@Hilbrand Hilbrand merged commit 85d216e into openhab:2.5.x Jul 28, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 28, 2020
@bobadair bobadair deleted the lutronsysvar branch July 28, 2020 14:22
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@bobadair @MPH80
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
a3f9be8 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
60c768b 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
d2bbe26 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
24f607e 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
d6e127f 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@bobadair @DaanMeijer
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
ebab469 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
@bobadair @CSchlipp
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
973b805 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@bobadair @markus7017
[lutron] Add sysvar handler for HomeWorks QS (openhab#8132)
4433d47 
* Add new sysvar thing
* Add internal support for SYSVAR and SHADEGRP protocol commands
* Enable sysvar monitoring in bridge when needed

Signed-off-by: Bob Adair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

Assignees
No one assigned
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Milestone
2.5.8
Development

Successfully merging this pull request may close these issues.
3 participants
@bobadair @TravisBuddy @Hilbrand