Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[adorne] Add https for website (otherwise the link is not recognized) #8103

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

andreasscherbaum
Copy link

Legrand website was just used as name, however in Markup syntax. This results in an invalid link:

https://www.openhab.org/addons/bindings/adorne/legrand.com

@TravisBuddy
Copy link

Travis tests were successful

Hey @andreasscherbaum,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @andreasscherbaum,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer changed the title Add https for website (otherwise the link is not recognized) [adorne] Add https for website (otherwise the link is not recognized) Jul 10, 2020
@kaikreuzer kaikreuzer merged commit 30017d2 into openhab:2.5.x Jul 10, 2020
@andreasscherbaum andreasscherbaum deleted the adorne_website branch July 10, 2020 22:23
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 12, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants