[infrastructure] enable spotless #8068
Conversation
Signed-off-by: Jan N. Klug <[email protected]>
Signed-off-by: Jan N. Klug <[email protected]>
J-N-K
requested review from
3cky,
9037568,
alexf2015,
andrewfg,
berndpfrommer,
bjoernbrings,
bobadair,
BobRak,
caffineehacker,
cdjackson,
chaton78,
claell,
clinique,
Confectrician,
Cossey,
cpmeister,
CrackerStealth,
crnjan,
cschneider,
cweitkamp,
davidgraeff,
DerOetzi,
digitaldan,
dominicdesu,
druciak,
fa2k,
FlorianSW and
fruggy83
as code owners
Signed-off-by: Jan N. Klug <[email protected]>
|
Hey @J-N-K, TravisCI finished with status TravisBuddy Request Identifier: 4287ca80-be09-11ea-a595-8f8781864445 |
|
This will certainly introduce conflicts with my PR #8057 :( If mine could be merged first, I would be happy. |
Travis tests were successfulHey @J-N-K, |
| <description>This is the Subscription Key provided by BTicino/Legrand when you subscribe to Smarther - v2.0 product. | ||
| Go to | ||
| https://developer.legrand.com/tutorials/getting-started/</description> |
There was a problem hiding this comment.
The formatting of the descriptions in this file probably needs to be manually adjusted.
There was a problem hiding this comment.
Manually adjusting the formatting is exactly what we want to avoid with the spotless formatter, or am I wrong there?
| if (this == object) | ||
| return true; | ||
| if (object == null || getClass() != object.getClass()) | ||
| return false; |
There was a problem hiding this comment.
Shouldn't if statements have brackets? Are brackets not enforced by spotless?
There was a problem hiding this comment.
Probably not. But changing that is out-of-scope of this PR.
|
Maybe you can fix the merge conflicts so we can merge this @J-N-K? |
| @@ -76,8 +78,7 @@ | |||
| <bnd.includeresource>-${.}/NOTICE, -${.}/*.xsd</bnd.includeresource> | |||
|
|
|||
| <feature.directory>src/main/feature/feature.xml</feature.directory> | |||
| <spotless.check.skip>true</spotless.check.skip> <!-- Spotless disabled for now --> | |||
| <spotless.version>1.31.1</spotless.version> | |||
| <spotless.version>2.0.0</spotless.version> | |||
There was a problem hiding this comment.
There are also a few newer versions nowadays, see changelog:
| <spotless.version>2.0.0</spotless.version> | |
| <spotless.version>2.0.3</spotless.version> |
|
Replaced by #8401. |
This PR finally enables spotless. After the upgrade to 2.0.0 the memory issues are fixe. The feature-bundles are excludedfor the moment because enabling the extensions for the karaf-maven-plugin currently breaks the build. This seems to be an issue in either the plugin or in maven, as one of them changes the line-endings-property of the build system.