Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[opensprinkler] Fix channel names in README example items. #8053

Merged
merged 1 commit into from
Jul 2, 2020
Merged

[opensprinkler] Fix channel names in README example items. #8053

merged 1 commit into from
Jul 2, 2020

Conversation

berland
Copy link
Contributor

@berland berland commented Jul 1, 2020

Fix channel link in example items

The example items in the README refers to station where it should be device.

@TravisBuddy
Copy link

Travis tests were successful

Hey @berland,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

FlorianSW
FlorianSW approved these changes Jul 1, 2020
View reviewed changes
Copy link
Member

@FlorianSW FlorianSW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching and fixing :)

@Hilbrand Hilbrand merged commit 9f535cf into openhab:2.5.x Jul 2, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jul 7, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@berland @knikhilwiz
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
127a413 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@berland @CSchlipp
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
47683ea 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption

Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@berland @MPH80
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
afa9797 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption

Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@berland @andrewfg
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
3f0312b 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@berland @andrewfg
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
c51ffa9 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@berland @andrewfg
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
110fce6 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@berland @andrewfg
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
b2ea4d5 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@berland @DaanMeijer
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
43d1875 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption

Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@berland @markus7017
[opensprinkler] Fix channel name for OpenSprinkler currentDraw in REA…
ba6602f 
…DME (openhab#8053)

Merged without sign-off under small document changes exemption
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@FlorianSW FlorianSW FlorianSW approved these changes

@CrackerStealth CrackerStealth Awaiting requested review from CrackerStealth CrackerStealth is a code owner

Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
5 participants
@berland @TravisBuddy @Hilbrand @FlorianSW @cpmeister