Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[innogysmarthome] Updated Auth-links in docs #8039

Merged
merged 5 commits into from
Jun 29, 2020
Merged

[innogysmarthome] Updated Auth-links in docs #8039

merged 5 commits into from
Jun 29, 2020

Conversation

mmans
Copy link

@mmans mmans commented Jun 29, 2020

Since the last backend-update the auth-links of Innogy are changed.

@mmans mmans requested a review from ollie-dev as a code owner June 29, 2020 08:36
Updated Auth-links
04a162e 
Signed-off-by: Marco Mans <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Found some other auth links
1e73c6d 
Signed-off-by: Marco Mans <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Immer diese Umlaute :(
9e147da 
Signed-off-by: Marco Mans <[email protected]>
@mmans
Copy link
Author

mmans commented Jun 29, 2020

mmmmh.... Jenkins fails on a binding that I didn't touch :(

retrigger
1964131 
Signed-off-by: Marco Mans <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Hilbrand
Hilbrand reviewed Jun 29, 2020
View reviewed changes
...hab.binding.innogysmarthome/src/main/resources/ESH-INF/i18n/innogysmarthome_de_DE.properties Outdated
@@ -4,17 +4,17 @@ binding.innogysmarthome.description = Das innogy SmartHome Binding verbindet Dei

# thing types
thing-type.innogysmarthome.bridge.label = innogy SmartHome Zentrale
thing-type.innogysmarthome.bridge.description = Der innogy SmartHome Controller (SHC) ist die Zentrale f�r das innogy SmartHome System.
thing-type.innogysmarthome.bridge.description = Der innogy SmartHome Controller (SHC) ist die Zentrale für das innogy SmartHome System.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happend here? Did you change line endings? Where they wrong? or did you editor break the encoding of this file?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep. after commit i saw that the encoding was broken. so i had to fix all "umlauts"

Copy link
Member

@Hilbrand Hilbrand Jun 29, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happend is. This file should be encoded ISO-8859 as per definition of java properties files. You saved it and it was converted to UTF-8, which causes the umlauts to become broken. You then 'fixed' the umlauts. However the file is now encoded UTF-8 instead of ISO-8859. Which is why it shows up as a diff here on GitHub.

Did you make any changes to this file? I can't find a change. In which case you should just reset it to the original file.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for your explanation. I just changed the auth url. I will fix this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always had this kind of encoding problems. Now I know why... after all those years :D You're never too old to learn. Thx again!

Fix encoding
44c8f47 
Signed-off-by: Marco Mans <[email protected]>
@mmans mmans requested a review from Hilbrand June 29, 2020 13:52
@TravisBuddy
Copy link

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@Hilbrand Hilbrand merged commit 4c2f4f6 into openhab:2.5.x Jun 29, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jun 29, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@mmans @knikhilwiz
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
3ea3959 
Signed-off-by: Marco Mans <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@mmans @CSchlipp
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
695d3b7 
Signed-off-by: Marco Mans <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@mmans @MPH80
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
f554521 
Signed-off-by: Marco Mans <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mmans @andrewfg
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
f813eea 
Signed-off-by: Marco Mans <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mmans @andrewfg
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
6d00926 
Signed-off-by: Marco Mans <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mmans @andrewfg
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
cf95c03 
Signed-off-by: Marco Mans <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@mmans @andrewfg
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
ee27e8a 
Signed-off-by: Marco Mans <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@mmans @DaanMeijer
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
d50f3f3 
Signed-off-by: Marco Mans <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@mmans @markus7017
[innogysmarthome] Updated Auth-links in docs (openhab#8039)
fbadf45 
Signed-off-by: Marco Mans <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hilbrand Hilbrand Hilbrand approved these changes

@ollie-dev ollie-dev Awaiting requested review from ollie-dev ollie-dev is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
4 participants
@mmans @TravisBuddy @Hilbrand @cpmeister