[hue] Reduce the number of warnings #8015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurent Garnier <[email protected]>
DerOetzi
requested changes
Jun 26, 2020
| @@ -42,6 +42,7 @@ public void setIpAddress(String ipAddress) { | |||
| } | |||
|
|
|||
| public int getPort() { | |||
| Integer port = this.port; | |||
There was a problem hiding this comment.
Maybe better to use localPort or checkPort or something to avoid "hidding" of class member.
| if (scheduledFuture != null) { | ||
| scheduledFuture.cancel(true); | ||
| scheduledFuture = null; | ||
| this.scheduledFuture = null; |
There was a problem hiding this comment.
In my opinion renaming the local variable would be a better pattern instead of using this operator?
| if (scheduledFuture != null) { | ||
| scheduledFuture.cancel(true); | ||
| scheduledFuture = null; | ||
| this.scheduledFuture = null; |
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Laurent Garnier <[email protected]>
|
@DerOetzi : as you reviewed and requested changes and as I handle them, can you please now approve this PR? |
DerOetzi
approved these changes
Jul 1, 2020
|
LGTM |
|
@openhab/add-ons-maintainers : could you please review and merge this small PR ? |
|
Thank you |
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* Review comments considered * Last minor change Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Laurent Garnier [email protected]