Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[modbus] Use RuntimeException #8007

Merged
merged 1 commit into from
Jun 24, 2020
Merged

Conversation

ssalonen
Copy link
Contributor

Using RuntimeException in the catch-all.

Cc @Hilbrand, similar discussion with dynamodb bundle change #8000 (review)

Signed-off-by: Sami Salonen [email protected]

Signed-off-by: Sami Salonen <[email protected]>
@ssalonen ssalonen changed the base branch from ssalonen-patch-1 to 2.5.x June 24, 2020 17:56
@TravisBuddy
Copy link

Hey @ssalonen,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 0c4c6d50-b647-11ea-aaf6-456b40a357ff

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 5bde9d6 into openhab:2.5.x Jun 24, 2020
@cpmeister cpmeister added this to the 2.5.7 milestone Jun 24, 2020
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
Signed-off-by: Sami Salonen <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
Signed-off-by: Sami Salonen <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
Signed-off-by: Sami Salonen <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants