Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[netatmo] The lastEvent is detected/compared incorrectly (#7963) #7964

Merged
merged 8 commits into from
Jun 20, 2020
Merged

[netatmo] The lastEvent is detected/compared incorrectly (#7963) #7964

merged 8 commits into from
Jun 20, 2020

Conversation

Novanic
Copy link
Contributor

@Novanic Novanic commented Jun 20, 2020

see issue #7963 . The bug exists since 2.5.6 and should get solved immediately with 2.5.6.

@Novanic
Copy link
Contributor Author

Novanic commented Jun 20, 2020 •
edited
Loading

I will also add some tests for NAWelcomeHomeHandler so such a mistake can't occur again. I didn't detected the error and the code-review was also not enough. ;-)

Please review this pull-request soon because the bug shouldn't go productive with 2.5.6.

@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @Novanic,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@sstrohschein
Tests regarding lastEvent added
dd63d5c 
Signed-off-by: Sven Strohschein <[email protected]>
@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label Jun 20, 2020
cpmeister
cpmeister approved these changes Jun 20, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 1ba697f into openhab:2.5.x Jun 20, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 20, 2020
@cpmeister cpmeister linked an issue Jun 20, 2020 that may be closed by this pull request
[netatmo] The lastEvent is detected/compared incorrectly #7963
Closed
@TravisBuddy
Copy link

Hey @Novanic,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 75b14000-b344-11ea-894e-97d5968798bd

knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@Novanic @knikhilwiz
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
45b49d8 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@Novanic @CSchlipp
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
3c375c1 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@Novanic @MPH80
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
4c23fdc 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
27d2486 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
0b7a2a7 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
b953c30 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@Novanic @andrewfg
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
41a2848 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@Novanic @DaanMeijer
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
16238e0 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@Novanic @markus7017
[netatmo] The lastEvent is detected/compared incorrectly (openhab#7963)…
92287aa 
… (openhab#7964)

* Bug-fix - The last event wasn't detected/compared correctly...
* Tests regarding lastEvent added

Signed-off-by: Sven Strohschein <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@clinique clinique Awaiting requested review from clinique clinique is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@lolodomo lolodomo Awaiting requested review from lolodomo lolodomo is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.

[netatmo] The lastEvent is detected/compared incorrectly
4 participants
@Novanic @TravisBuddy @cpmeister @sstrohschein