[innogysmarthome] Fix Battery Warnings (Bug

[mmans]

This PR fixes low battery messages.
Closes: #6932

Root cause: Json field "DeviceLinkList" of a "Message" is renamed (by Innogy) to "Devices".

[TravisBuddy]

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[cpmeister]

I assume that "DeviceLinkList" is still used for other types of messages so shouldn't you use both then?

[mmans]

Good question. It is only used in a "Message". And the only function that uses the getDeviceLinkList is the LowBattery message. So I thought it could do no harm to change it. If other messages are implemented in the future it could change.

[Hilbrand]

This change is correct. It looks like with the change to the new innogy api 1.1 some information got lost in the Message class. While some data structures changed in the new api, the changes lost some information. Partly because the json parsing was also changed. So places that used @Key. didn't get a @SerializedName annotation. In this case it had the @Key("Devices"). But besides it being renamed to the lower case devices in the new api, the @SerializedName annotation was not added. I see there are also to other annotations missing:

• Field isRead should get the annotation @SerializedName("read")
• Field messageClass should get the annotation @SerializedName("class").

The change here of the field name to devices is ok. But please do also update the javadoc and method parameter in the Message.java class. And while you change that can you also add the 2 other annotations.

So the use of deviceLinkList is not something that will be present in json and this change should not be a problem.

[mmans]

Hi @Hilbrand

Thanks for your review. I changed the things you mentioned.

Regards,
Marco

[TravisBuddy]

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[TravisBuddy]

Travis tests were successful

Hey @mmans,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

[Hilbrand]

LGTM