[homekit] fix corrupt storage #7940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eugen Freiter <[email protected]>
cpmeister
requested changes
Jun 19, 2020
...penhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitCommandExtension.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/Debouncer.java
Show resolved
Hide resolved
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/Debouncer.java
Show resolved
Hide resolved
cpmeister
added
the
bug
Signed-off-by: Eugen Freiter <[email protected]>
cpmeister
requested changes
Jun 19, 2020
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitImpl.java
Outdated
Show resolved
Hide resolved
bundles/org.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/Debouncer.java
Show resolved
Hide resolved
...rg.openhab.io.homekit/src/main/java/org/openhab/io/homekit/internal/HomekitAuthInfoImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Eugen Freiter <[email protected]>
Travis tests were successfulHey @yfre, |
cpmeister
approved these changes
Jun 20, 2020
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: CSchlipp <[email protected]>
MPH80
pushed a commit
to MPH80/openhab-addons
that referenced
this pull request
Aug 3, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: MPH80 <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* fix for race conditions * incorporate feedback * reduce number of interactions with the storage. fix bug in clear method Signed-off-by: Eugen Freiter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
there are regular reports about "lost mac address" issue.
https://community.openhab.org/t/homekit-could-not-find-existing-mac/100845/8
https://community.openhab.org/t/need-to-reset-homekit-pairing-at-every-launch/13542/32
sometimes the mac address disappears from homekit.json and one need to repair home clients with openhab.
this issue is difficult to reproduce. there is no place in the source code where mac address gets removed from storage. there are only 2 places related to mac address: one is writing new mac to storage, another one is reading the mac from storage.
so, must be something like race condition and inconsistent state of the storage object
this PR reduces number of class which have references to storage object. it also stops a runnable that could potential try to update storage at binding stop/shutdown event.
changes:
it is unclear whether it will fix the issue but imho it is at least an improvement of the storage handling and shutdown process
Signed-off-by: Eugen Freiter [email protected]