Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[astro] Suppress timeZoneProvider global variable #7895

Merged
merged 1 commit into from
Jun 13, 2020
Merged

[astro] Suppress timeZoneProvider global variable #7895

merged 1 commit into from
Jun 13, 2020

Conversation

lolodomo
Copy link
Contributor

Signed-off-by: Laurent Garnier [email protected]

@lolodomo lolodomo requested a review from gerrieg as a code owner June 11, 2020 06:44
@lolodomo lolodomo changed the title [astro] Suppress a global variable [WIP][astro] Suppress a global variable Jun 11, 2020
@lolodomo lolodomo added the work in progress A PR that is not yet ready to be merged label Jun 11, 2020
@TravisBuddy
Copy link

Travis tests were successful

Hey @lolodomo,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@lolodomo lolodomo force-pushed the astro_avoidglobal branch from b1bf579 to 2ae1b01 Compare June 13, 2020 12:06
@lolodomo lolodomo changed the title [WIP][astro] Suppress a global variable [astro] Suppress timeZoneProvider global variable Jun 13, 2020
@lolodomo lolodomo removed the work in progress A PR that is not yet ready to be merged label Jun 13, 2020
cpmeister
cpmeister approved these changes Jun 13, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit fb10e6f into openhab:2.5.x Jun 13, 2020
@cpmeister cpmeister added this to the 2.5.6 milestone Jun 13, 2020
@lolodomo lolodomo deleted the astro_avoidglobal branch June 13, 2020 20:58
knikhilwiz pushed a commit to knikhilwiz/openhab2-addons that referenced this pull request Jul 12, 2020
@lolodomo @knikhilwiz
[astro] Suppress timeZoneProvider global variable (openhab#7895)
4abfb81 
Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@lolodomo @CSchlipp
[astro] Suppress timeZoneProvider global variable (openhab#7895)
01786bf 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[astro] Suppress timeZoneProvider global variable (openhab#7895)
a883d97 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[astro] Suppress timeZoneProvider global variable (openhab#7895)
d3f5ce6 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[astro] Suppress timeZoneProvider global variable (openhab#7895)
5e856b9 
Signed-off-by: Laurent Garnier <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@lolodomo @andrewfg
[astro] Suppress timeZoneProvider global variable (openhab#7895)
ab32e8e 
Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@lolodomo @DaanMeijer
[astro] Suppress timeZoneProvider global variable (openhab#7895)
36ea272 
Signed-off-by: Laurent Garnier <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@lolodomo @markus7017
[astro] Suppress timeZoneProvider global variable (openhab#7895)
eb0be73 
Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@gerrieg gerrieg Awaiting requested review from gerrieg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
3 participants
@lolodomo @TravisBuddy @cpmeister