[astro] Discovery service with constructor injection #7850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Null annotations added. Signed-off-by: Laurent Garnier <[email protected]>
|
I will update accordingly once the first PR is merged |
cpmeister
requested changes
Jun 10, 2020
Comment on lines
64
to
68
| final @Reference LocaleProvider localeProvider, final @Reference TranslationProvider i18nProvider) { | ||
| super(new HashSet<>(Arrays.asList(new ThingTypeUID(BINDING_ID, "-"))), DISCOVER_TIMEOUT_SECONDS, true); | ||
| this.locationProvider = locationProvider; | ||
| this.localeProvider = localeProvider; | ||
| this.i18nProvider = i18nProvider; |
There was a problem hiding this comment.
You need to call activate otherwise background discovery will not start.
Suggested change
| final @Reference LocaleProvider localeProvider, final @Reference TranslationProvider i18nProvider) { | |
| super(new HashSet<>(Arrays.asList(new ThingTypeUID(BINDING_ID, "-"))), DISCOVER_TIMEOUT_SECONDS, true); | |
| this.locationProvider = locationProvider; | |
| this.localeProvider = localeProvider; | |
| this.i18nProvider = i18nProvider; | |
| final @Reference LocaleProvider localeProvider, final @Reference TranslationProvider i18nProvider, | |
| Map<String, Object> configProperties) { | |
| super(new HashSet<>(Arrays.asList(new ThingTypeUID(BINDING_ID, "-"))), DISCOVER_TIMEOUT_SECONDS, true); | |
| this.locationProvider = locationProvider; | |
| this.localeProvider = localeProvider; | |
| this.i18nProvider = i18nProvider; | |
| activate(configProperties); |
Signed-off-by: Laurent Garnier <[email protected]>
Travis tests have failedHey @lolodomo, |
knikhilwiz
pushed a commit
to knikhilwiz/openhab2-addons
that referenced
this pull request
Jul 12, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]>
CSchlipp
pushed a commit
to CSchlipp/openhab-addons
that referenced
this pull request
Jul 26, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: CSchlipp <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]>
andrewfg
pushed a commit
to andrewfg/openhab-addons
that referenced
this pull request
Aug 31, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]>
DaanMeijer
pushed a commit
to DaanMeijer/openhab-addons
that referenced
this pull request
Sep 1, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
markus7017
pushed a commit
to markus7017/openhab-addons
that referenced
this pull request
Sep 19, 2020
* [astro] Discovery service with constructor injection Null annotations added. * Call activate in the constructor Signed-off-by: Laurent Garnier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Null annotations added.
Signed-off-by: Laurent Garnier [email protected]