-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[oppo] Oppo Blu-ray Player Binding - initial contribution #7746
Conversation
update fork
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests have failedHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
update fork
Hi @mlobstein, |
@meli-san The last channel in the binding is 'remote_button'.... You can send the string "EJT" to eject the disc. oppo_remote_button.sendCommand("EJT") |
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
update fork
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
1 similar comment
Travis tests were successfulHey @mlobstein, |
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks great. Just some small comments.
bundles/org.openhab.binding.oppo/src/main/resources/ESH-INF/thing/channels.xml
Outdated
Show resolved
Hide resolved
....binding.oppo/src/main/java/org/openhab/binding/oppo/internal/communication/OppoCommand.java
Outdated
Show resolved
Hide resolved
...ing.oppo/src/main/java/org/openhab/binding/oppo/internal/discovery/OppoDiscoveryService.java
Outdated
Show resolved
Hide resolved
...inding.oppo/src/main/java/org/openhab/binding/oppo/internal/communication/OppoConnector.java
Outdated
Show resolved
Hide resolved
...penhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/handler/OppoHandler.java
Outdated
Show resolved
Hide resolved
...enhab.binding.oppo/src/main/java/org/openhab/binding/oppo/internal/OppoBindingConstants.java
Show resolved
Hide resolved
Signed-off-by: Michael Lobstein <[email protected]>
Travis tests were successfulHey @mlobstein, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: MPH80 <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]> Signed-off-by: Daan Meijer <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
Signed-off-by: Michael Lobstein <[email protected]>
[oppo] Initial contribution
This is the initial implementation of a Binding to control the Oppo UDP-203/205 or BDP-83/93/95/103/105 Blu-ray player. Almost all features of the various models of this player line are supported by the binding. Since I only have a BDP-103 to test with there might be some issues with
other models that will need to be fixed. Please report any issues found.