Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oppo] Oppo Blu-ray Player Binding - initial contribution #7746

Merged
merged 25 commits into from
Jul 28, 2020

Conversation

mlobstein
Copy link
Contributor

[oppo] Initial contribution

This is the initial implementation of a Binding to control the Oppo UDP-203/205 or BDP-83/93/95/103/105 Blu-ray player. Almost all features of the various models of this player line are supported by the binding. Since I only have a BDP-103 to test with there might be some issues with
other models that will need to be fixed. Please report any issues found.

@mlobstein mlobstein requested a review from a team as a code owner May 22, 2020 21:06
@mlobstein
Copy link
Contributor Author

mlobstein commented May 22, 2020

@TravisBuddy
Copy link

Travis tests have failed

Hey @mlobstein,
please read the following log in order to understand the failure reason. There might also be some helpful tips along the way.
It will be awesome if you fix what is wrong and commit the changes.

Signed-off-by: Michael Lobstein <[email protected]>
@cpmeister cpmeister added the new binding If someone has started to work on a binding. For a new binding PR. label May 23, 2020
Signed-off-by: Michael Lobstein <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mlobstein
Copy link
Contributor Author

mlobstein commented Jun 3, 2020

@fwolter
Hold off on reviewing until #7371 is sorted out. This binding's Connector classes are of the same derivative, so I will need to make the requested changes here also.

@meli-san
Copy link

meli-san commented Jun 5, 2020

Hi @mlobstein,
Congratulations on your idea, I want to help you
I am not a programmer but I can be a tester, udp-203 player
btw: how to send the most important command, eject disk? :)

@mlobstein
Copy link
Contributor Author

Hi @mlobstein,
Congratulations on your idea, I want to help you
I am not a programmer but I can be a tester, udp-203 player
btw: how to send the most important command, eject disk? :)

@meli-san
Be sure and read through the README here:
https://github.com/openhab/openhab-addons/pull/7746/files#diff-329d49cb6cc62f783e77fd05990e2223

The last channel in the binding is 'remote_button'.... You can send the string "EJT" to eject the disc.
If you use the manual channel setup described in the readme, the command would be:

oppo_remote_button.sendCommand("EJT")

@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Michael Lobstein <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mlobstein mlobstein requested a review from fwolter July 25, 2020 03:02
@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

1 similar comment
@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Signed-off-by: Michael Lobstein <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fwolter fwolter added the cre Coordinated Review Effort label Jul 27, 2020
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks great. Just some small comments.

Signed-off-by: Michael Lobstein <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @mlobstein,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@mlobstein mlobstein requested a review from Hilbrand July 27, 2020 22:12
Copy link
Member

@Hilbrand Hilbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Hilbrand Hilbrand merged commit e948595 into openhab:2.5.x Jul 28, 2020
@Hilbrand Hilbrand removed the cre Coordinated Review Effort label Jul 28, 2020
@Hilbrand Hilbrand added this to the 2.5.8 milestone Jul 28, 2020
@mlobstein mlobstein deleted the OppoBluRay branch July 28, 2020 15:20
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Sep 12, 2020
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants