Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[homekit] bugfix 7701. add delay on homekit bridge start in case of configuration diffs #7725

Merged
merged 2 commits into from
May 22, 2020
Merged

[homekit] bugfix 7701. add delay on homekit bridge start in case of configuration diffs #7725

merged 2 commits into from
May 22, 2020

Conversation

yfre
Copy link
Contributor

@yfre yfre commented May 21, 2020

another fix for #7701 as proposed by @J-N-K in PR #7702

background:

  • home app resets sometimes configuration, e.g. losing scenes, room assignments, etc.
  • potential reason: if HomeKit bridge starts before all items have been initialised / bundles started then home app will receive a shorter list of accessories than it has expected and could reset the configuration, e.g. remove missing items.

solution:

  • store number of accessories / items from last known configuration
  • compare number of accessories on start with last known configuration
  • delay HomeKit bridge start for 30 seconds (configurable) in case the current number of accessories is lower than last known configuration

Signed-off-by: Eugen Freiter [email protected]

add start delay in case of configuration differences. this reduces th…
f90d09b 
…e risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
@yfre yfre requested a review from J-N-K May 21, 2020 22:05
@TravisBuddy
Copy link

Travis tests were successful

Hey @yfre,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

J-N-K
J-N-K requested changes May 22, 2020
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

incorporate J-N-K feedback
7062c9c 
Signed-off-by: Eugen Freiter <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @yfre,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@J-N-K J-N-K merged commit 21121a7 into openhab:2.5.x May 22, 2020
@J-N-K J-N-K added the bug An unexpected problem or unintended behavior of an add-on label May 22, 2020
@J-N-K J-N-K added this to the 2.5.6 milestone May 22, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@yfre @LoungeFlyZ
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
457f813 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
@yfre yfre deleted the add_delay branch June 20, 2020 17:29
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@yfre @J-N-K
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
2e2d9c1 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@yfre @CSchlipp
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
ad338ff 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@yfre @andrewfg
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
b4e7649 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@yfre @andrewfg
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
151be91 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@yfre @andrewfg
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
f70528d 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@yfre @andrewfg
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
03674c3 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@yfre @DaanMeijer
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
0345017 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@yfre @markus7017
[homekit] bugfix 7701. add delay on homekit bridge start in case of c…
d310ee5 
…onfiguration diffs (openhab#7725)

* add start delay in case of configuration differences. this reduces the risk of home app settings reset

Signed-off-by: Eugen Freiter <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.6
Development

Successfully merging this pull request may close these issues.
3 participants
@yfre @TravisBuddy @J-N-K