Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[alarmdecoder] Remove check for no serial ports #7615

Merged
merged 1 commit into from
May 12, 2020
Merged

[alarmdecoder] Remove check for no serial ports #7615

merged 1 commit into from
May 12, 2020

Conversation

bobadair
Copy link
Member

Remove check for no serial ports, as it seems to be no longer necessary and keeps RFC2217 connections from working. See #7609 and openhab/openhab-core#1462 for details.

@bobadair bobadair requested a review from berndpfrommer as a code owner May 12, 2020 19:33
@bobadair bobadair mentioned this pull request May 12, 2020
Merged
@TravisBuddy
Copy link

Travis tests were successful

Hey @bobadair,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

wborn
wborn approved these changes May 12, 2020
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It will also prevent others from introducing the same issue if they would copy/paste this code. 👍

@wborn wborn merged commit 526ac43 into openhab:2.5.x May 12, 2020
@bobadair bobadair deleted the alarmdecoderupd branch May 12, 2020 20:04
@cpmeister cpmeister added this to the 2.5.5 milestone May 12, 2020
@cpmeister cpmeister added the bug An unexpected problem or unintended behavior of an add-on label May 12, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@bobadair @LoungeFlyZ
[alarmdecoder] Remove check for no serial ports (openhab#7615)
f70fb4f 
Signed-off-by: Bob Adair <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@bobadair @J-N-K
[alarmdecoder] Remove check for no serial ports (openhab#7615)
8fafe46 
Signed-off-by: Bob Adair <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@bobadair @CSchlipp
[alarmdecoder] Remove check for no serial ports (openhab#7615)
b348345 
Signed-off-by: Bob Adair <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[alarmdecoder] Remove check for no serial ports (openhab#7615)
8e931fb 
Signed-off-by: Bob Adair <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[alarmdecoder] Remove check for no serial ports (openhab#7615)
98ca67e 
Signed-off-by: Bob Adair <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[alarmdecoder] Remove check for no serial ports (openhab#7615)
65ffa3b 
Signed-off-by: Bob Adair <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@bobadair @andrewfg
[alarmdecoder] Remove check for no serial ports (openhab#7615)
ff5f0b9 
Signed-off-by: Bob Adair <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@bobadair @DaanMeijer
[alarmdecoder] Remove check for no serial ports (openhab#7615)
84da97a 
Signed-off-by: Bob Adair <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@bobadair @markus7017
[alarmdecoder] Remove check for no serial ports (openhab#7615)
e7fae89 
Signed-off-by: Bob Adair <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@berndpfrommer berndpfrommer Awaiting requested review from berndpfrommer

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
2.5.5
Development

Successfully merging this pull request may close these issues.
4 participants
@bobadair @TravisBuddy @wborn @cpmeister