[WIP][emby] Initial Contribution #7575

volfan6415 · 2020-05-08T17:27:07Z

So i have developed a binding to interface with EMBY Media Server (https://emby.media/). EMBY is a PLEX alternative and the binding provides many of the same features for users of EMBY as the PLEX binding does for uses of PLEX.

I have had users using an earlier version of the binding (prior to cleanup commits that i did before making this pull request) for over a 1.5 now and i have been using it myself for that long as well. It has worked well for the users that have tested it for me. (see https://community.openhab.org/t/new-binding-emby-server-binding-alpha/54010)

I would like to start making the necessary changes that i know need to be made to get this code cleaned up and optimized so that it can be incorporated as an official binding.

I know i need to do some things still but i know there will be others that i don't now about, hence, the pull request. I would say the binding in its current state is beta. The core works well but there are features that i could possibly add and changes which need to be made.

One thing i know I will need some clarification on is the author signing. In developing this binding i started with the KODI binding code, as EMBY provides a similar websocket api. I did have to make extensive changes to make it work with EMBY, however, there is definitively a structure left from the KODI binding and there are some methods and classes where the only real change was method/class names. I unfortunately in making these changes did not keep the author tags on the classes and now have all of the classes showing me as the original contribution. I know this is wrong. What is the best way to handle this?

I know there are significant updates which need to be made to the readme and I will be working on those put wanted to start this pull request so i could get some comments and suggestions on the underlying code before i spend too much time on the readme as that may very well change.

Open to all input as to what needs to be done to get this binding where it can be submitted.

*add additional control options *various bug fixes and code cleanup to prepare for pull request Signed-off-by: Zachary Christiansen <[email protected]>

* Code cleanup after running code analysis * optimizations toimprove null handling Signed-off-by: Zachary Christiansen <[email protected]>

fwolter · 2020-07-26T22:06:22Z

@volfan6415 What's the current state of this PR? Are you interested in a code review?

volfan6415 · 2020-07-27T16:30:09Z

Yes i would like a code review. I have a hunch that there will need to be some changes so would love the review to get an idea on what i should do.

Thanks

-updates to allow for control play command to be sent when nothing is actively playing Signed-off-by: Zachary Christiansen <[email protected]>

volfan6415 · 2020-09-03T17:50:10Z

I know the review can take awhile. But will i get a review on this binding or will it have to wait until 3.0 is out?

fwolter · 2020-09-03T17:53:21Z

It's on my TODO list. I'll try to get ready before 2.5.9. In the meantime, you could solve the conflicting pom.xml.

fwolter

Sorry for the delay, I reviewed your code and here is my feedback.

There are some checkstyle warnings left. You could take a look at target/code-analysis/report.html.

There are some formatting issues. You can view them with mvn spotless:check -Dspotless.check.skip=false and fix them with mvn spotless:apply.