Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[velux] Avoiding warning about (yet) unrecognized actuators #7379

Merged
merged 1 commit into from
Apr 15, 2020
Merged

[velux] Avoiding warning about (yet) unrecognized actuators #7379

merged 1 commit into from
Apr 15, 2020

Conversation

gs4711
Copy link
Contributor

@gs4711 gs4711 commented Apr 15, 2020

especially during startup phase of the binding.

…ng startup phase. (#abcd)

Signed-off-by: Guenther Schreiner <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @gs4711,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 4a4459a into openhab:2.5.x Apr 15, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 15, 2020
@cpmeister cpmeister added the enhancement An enhancement or new feature for an existing add-on label Apr 15, 2020
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
…ng startup phase. (openhab#7379)

Signed-off-by: Guenther Schreiner <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@andrewfg
Copy link
Contributor

andrewfg commented Jun 12, 2020

Small point: I just noticed that on https://www.openhab.org/addons/bindings/velux/ the binding ReadMe carries the tag "v1" which given that it is a v2 binding is rather strange..

image

J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
…ng startup phase. (openhab#7379)

Signed-off-by: Guenther Schreiner <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
…ng startup phase. (openhab#7379)

Signed-off-by: Guenther Schreiner <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants