Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[plugwise] Remove discovery for Stick #7359

Merged
merged 1 commit into from
Apr 13, 2020
Merged

[plugwise] Remove discovery for Stick #7359

merged 1 commit into from
Apr 13, 2020

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 13, 2020 •
edited
Loading

Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations. There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

@wborn
[plugwise] Remove discovery for Stick
0f0ad72 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
@wborn wborn force-pushed the plugwise-remove-stick-discovery branch from 0f0534e to 0f0ad72 Compare April 13, 2020 19:38
cpmeister
cpmeister reviewed Apr 13, 2020
View reviewed changes
bundles/org.openhab.binding.plugwise/README.md
@@ -23,7 +24,6 @@ The binding supports the following Plugwise devices:
## Discovery

Automatic device discovery runs every 3 minutes which can be sped up by starting a manual discovery.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there another discovery service other than the one you deleted?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the PlugwiseThingDiscoveryService :-)

cpmeister
cpmeister approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@cpmeister cpmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpmeister cpmeister merged commit 4ea0ce1 into openhab:2.5.x Apr 13, 2020
@cpmeister cpmeister added this to the 2.5.4 milestone Apr 13, 2020
@wborn wborn deleted the plugwise-remove-stick-discovery branch April 13, 2020 20:23
yfre pushed a commit to yfre/openhab-addons that referenced this pull request Apr 27, 2020
@wborn
[plugwise] Remove discovery for Stick (openhab#7359)
7fbf088 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Eugen Freiter <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request May 29, 2020
@wborn @markus7017
[plugwise] Remove discovery for Stick (openhab#7359)
e5332b9 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
LoungeFlyZ pushed a commit to LoungeFlyZ/openhab2-addons that referenced this pull request Jun 8, 2020
@wborn @LoungeFlyZ
[plugwise] Remove discovery for Stick (openhab#7359)
a4af924 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
J-N-K pushed a commit to J-N-K/openhab-addons that referenced this pull request Jul 14, 2020
@wborn @J-N-K
[plugwise] Remove discovery for Stick (openhab#7359)
03949dc 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@wborn @CSchlipp
[plugwise] Remove discovery for Stick (openhab#7359)
6722e3e 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
[plugwise] Remove discovery for Stick (openhab#7359)
d45ca4d 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
[plugwise] Remove discovery for Stick (openhab#7359)
cae6e9c 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
[plugwise] Remove discovery for Stick (openhab#7359)
9c86201 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@wborn @andrewfg
[plugwise] Remove discovery for Stick (openhab#7359)
d0bbb01 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@wborn @DaanMeijer
[plugwise] Remove discovery for Stick (openhab#7359)
7364f88 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@wborn @markus7017
[plugwise] Remove discovery for Stick (openhab#7359)
07a288d 
Sending messages to other serial devices may cause issues such as message corruption, locking issues and unwanted operations.
There's also a SerialConfigOptionProvider nowadays which simplifies selecting the Stick in UIs from all available serial devices.

Signed-off-by: Wouter Born <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5.4
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @cpmeister