Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][pushover] Migration of Pushover OH1 action to OH3 binding #6798

Closed
wants to merge 3 commits into from
Closed

[WIP][pushover] Migration of Pushover OH1 action to OH3 binding #6798

wants to merge 3 commits into from

Conversation

cweitkamp
Copy link
Contributor

  • Migration of Pushover action to OH3 binding

Signed-off-by: Christoph Weitkamp [email protected]

@cweitkamp cweitkamp added new binding If someone has started to work on a binding. For a new binding PR. work in progress A PR that is not yet ready to be merged oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 labels Jan 9, 2020
@Hilbrand Hilbrand mentioned this pull request Jan 9, 2020
Closed
@cweitkamp cweitkamp force-pushed the binding-pushover branch 3 times, most recently from 8795440 to 2fa81da Compare January 14, 2020 13:00
@cweitkamp cweitkamp requested a review from a team as a code owner July 6, 2020 16:09
@wborn
Copy link
Member

wborn commented Aug 22, 2020

Is there still a lot of WIP @cweitkamp? :-) Looks like I need these changes for migrating to OH3.

@cweitkamp
Implementation of Pushover binding
1da75f5 
Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp
Copy link
Contributor Author

@wborn Hm, I have to dig into it again. But IIRC the basic functions are already working. I now have to finish the README.md, the German translations and migrate the tests to JUnit 5 - will try to use your helper script in Gist. Maybe more.

Do you want to test it? Shall I provide a *.jar file or can you build it on your own 😉.

@cweitkamp
Migrate unit tests to JUnit 5
686cf61 
Signed-off-by: Christoph Weitkamp <[email protected]>
@wborn
Copy link
Member

wborn commented Aug 30, 2020

If it should already work, I will probably soon give it a try with a local build. 👍
But it seems to have some compilation issues now @cweitkamp.

@cweitkamp
Workaround for thing actions bug
c02434f 
Signed-off-by: Christoph Weitkamp <[email protected]>
@cweitkamp
Copy link
Contributor Author

@wborn I fixed it. I was working on ThingActions bug in parallel and thus some movements of classes were committed wrong.

@Hilbrand Hilbrand added the oh3 label Sep 7, 2020
@kaikreuzer kaikreuzer closed this Sep 20, 2020
@kaikreuzer
Copy link
Member

Could you please re-create this PR against the main branch?
See point (4) in #8512. Thanks!

@cweitkamp cweitkamp deleted the binding-pushover branch September 26, 2020 15:25
@cweitkamp cweitkamp restored the binding-pushover branch September 26, 2020 15:26
@cweitkamp cweitkamp deleted the binding-pushover branch September 26, 2020 15:27
@cweitkamp cweitkamp restored the binding-pushover branch September 26, 2020 15:27
@cweitkamp cweitkamp deleted the binding-pushover branch September 26, 2020 15:31
@cweitkamp cweitkamp restored the binding-pushover branch September 26, 2020 15:33
@cweitkamp cweitkamp deleted the binding-pushover branch September 26, 2020 15:42
@cweitkamp cweitkamp mentioned this pull request Sep 26, 2020
Merged
@wborn wborn removed the oh3 label Oct 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
new binding If someone has started to work on a binding. For a new binding PR. oh1 migration Relates to migrating an openHAB 1 addon to openHAB 2 work in progress A PR that is not yet ready to be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cweitkamp @wborn @kaikreuzer @Hilbrand