Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[caddx] Caddx NetworX alarm panel Binding initial contribution #6430

Merged
merged 77 commits into from
Jul 19, 2020
Merged

[caddx] Caddx NetworX alarm panel Binding initial contribution #6430

merged 77 commits into from
Jul 19, 2020

Conversation

jossuar
Copy link
Contributor

@jossuar jossuar commented Nov 20, 2019

[caddx] Caddx NetworX alarm panel Binding initial contribution

This binding adds support for the NetworX alarm panels.
To communicate with the panel a serial connection is required. Discovery is supported.
Relevant thread in the forum.

@jossuar jossuar requested a review from a team as a code owner November 20, 2019 22:19
@TravisBuddy
Copy link

Travis tests were successful

Hey @jossuar,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

jossuar added 15 commits July 19, 2020 20:37
@jossuar
CaddxBaseThingHandler modifications
bafe5c3 
Removed unneeded comment
Removed unneeded log
Removed unneeded bridgeStatusChanged function

Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
CaddxBridgeHandler changes
8104c6e 
Removed unneeded logging
Removed unneeded bridge_reset channel

Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Converted CaddxSource enum to uppercase
e7bdd68 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Converted LogEventType enum to upper case
3735d43 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Trivial ThingHandlerPanel changes
3c8c67b 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Amended readme file
ea2b665 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Readme changes
6662e82 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Removed duplicate entry in README
caba654 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Added representationProperty on the discovered things
4124a98 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Corrected command debug logging
bb0dc9b 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Deleted setters from the Configuration classes
e902d79 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Corrected ASCII protocol reception bug
1902f48 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Review changes
d9a2e7d 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Corrected serial port restart
4d38df0 
Signed-off-by: Georgios Moutsos <[email protected]>
@jossuar
Removed log message
a47d559 
Signed-off-by: Georgios Moutsos <[email protected]>
@TravisBuddy
Copy link

Travis tests were successful

Hey @jossuar,
we found no major flaws with your code. Still you might want to look at this logfile, as we usually suggest some optional improvements.

@jossuar
Copy link
Contributor Author

jossuar commented Jul 19, 2020

Nevermind. I found the following post from Confectrician.
https://community.openhab.org/t/dco-check-signing-off-with-github-web-editor-explanation/83330
I have to set correctly the user.name. $ git config --global user.name "John Doe"

fwolter
fwolter approved these changes Jul 19, 2020
View reviewed changes
Copy link
Member

@fwolter fwolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the link! That makes sense.

LGTM

@fwolter fwolter merged commit bb6722c into openhab:2.5.x Jul 19, 2020
@fwolter fwolter removed the cre Coordinated Review Effort label Jul 19, 2020
@fwolter fwolter added this to the 2.5.7 milestone Jul 19, 2020
@jossuar jossuar deleted the caddx branch July 21, 2020 18:07
CSchlipp pushed a commit to CSchlipp/openhab-addons that referenced this pull request Jul 26, 2020
@jossuar @CSchlipp
[caddx] Initial contribution (openhab#6430)
e7a716c 
Signed-off-by: Georgios Moutsos <[email protected]>
Signed-off-by: CSchlipp <[email protected]>
MPH80 pushed a commit to MPH80/openhab-addons that referenced this pull request Aug 3, 2020
@jossuar @MPH80
[caddx] Initial contribution (openhab#6430)
b9c3e88 
Signed-off-by: Georgios Moutsos <[email protected]>
Signed-off-by: MPH80 <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jossuar @andrewfg
[caddx] Initial contribution (openhab#6430)
acaabd6 
Signed-off-by: Georgios Moutsos <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jossuar @andrewfg
[caddx] Initial contribution (openhab#6430)
9814a9b 
Signed-off-by: Georgios Moutsos <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jossuar @andrewfg
[caddx] Initial contribution (openhab#6430)
1c32944 
Signed-off-by: Georgios Moutsos <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Aug 31, 2020
@jossuar @andrewfg
[caddx] Initial contribution (openhab#6430)
56b39fc 
Signed-off-by: Georgios Moutsos <[email protected]>
DaanMeijer pushed a commit to DaanMeijer/openhab-addons that referenced this pull request Sep 1, 2020
@jossuar @DaanMeijer
[caddx] Initial contribution (openhab#6430)
ba9d9e1 
Signed-off-by: Georgios Moutsos <[email protected]>
Signed-off-by: Daan Meijer <[email protected]>
markus7017 pushed a commit to markus7017/openhab-addons that referenced this pull request Sep 19, 2020
@jossuar @markus7017
[caddx] Initial contribution (openhab#6430)
14c996c 
Signed-off-by: Georgios Moutsos <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpmeister cpmeister cpmeister approved these changes

@fwolter fwolter fwolter approved these changes

@Hilbrand Hilbrand Awaiting requested review from Hilbrand

@marvkis marvkis Awaiting requested review from marvkis

@robnielsen robnielsen Awaiting requested review from robnielsen

@yfre yfre Awaiting requested review from yfre

Assignees

@fwolter fwolter

Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
2.5.7
Development

Successfully merging this pull request may close these issues.
6 participants
@jossuar @TravisBuddy @Hilbrand @cpmeister @fwolter @wborn