Added new lines at the end of files missing them #6340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hilbrand
requested review from
alexf2015,
cdjackson,
clinique,
Cossey,
crnjan,
cschneider,
davidgraeff,
digitaldan,
dominicdesu,
FlorianSW,
fruggy83,
gbicskei,
gerrieg,
J-N-K,
kaikreuzer,
klocsson,
limdul79,
marcelrv,
martinvw,
nikotanghe,
paulianttila,
ssalonen,
svilenvul and
a team
as code owners
clinique
approved these changes
Nov 4, 2019
Travis tests have failedHey @Hilbrand, 1st BuildExpand here |
wborn
approved these changes
Nov 4, 2019
There was a problem hiding this comment.
Thanks!
The bnd resolver has a habit to not end files with a new line. Maybe we should create a bnd issue for that?
It would also help, when processing files with scripts, if all files use the same OS specific line endings. Adding .gitattributes files to repos would help with that. See also this gitattributes template collection.
|
I couldn't find test results for IHC binding from the build. Changes to IHC binding resource files (xml files) might break some of the IHC binding tests as test check that generated SOAP messages are exactly the same as resource file content (resource file content is now changed because of new line). |
|
These were the test results for my local run for IHC: |
The Java 8 build succeeded, see: https://travis-ci.org/openhab/openhab2-addons/jobs/607042310 You can get there by clicking "View details" next to my "merged commit" action. Then click "Details" to the right of "The Travis CI build failed". For the Java 11 build failures see https://github.com/openhab/openhab2-addons/issues/6334. |
thewiep
pushed a commit
to thewiep/openhab-addons
that referenced
this pull request
Nov 23, 2019
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
roieg
pushed a commit
to roieg/openhab-addons
that referenced
this pull request
Nov 28, 2019
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Dec 8, 2019
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
roieg
pushed a commit
to roieg/openhab-addons
that referenced
this pull request
Dec 25, 2019
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
roieg
pushed a commit
to roieg/openhab-addons
that referenced
this pull request
Dec 26, 2019
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
tmrobert8
pushed a commit
to tmrobert8/openhab-addons
that referenced
this pull request
Jan 21, 2020
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Tim Roberts <[email protected]>
hww3
pushed a commit
to hww3/openhab2-addons
that referenced
this pull request
Feb 22, 2020
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]>
Hans-Reiner
pushed a commit
to Hans-Reiner/openhab2-addons
that referenced
this pull request
Apr 11, 2020
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line. Remove to .gitignore files that only contained target directory, which is covered by the root ignore file. Signed-off-by: Hilbrand Bouwkamp <[email protected]> Signed-off-by: Hans-Reiner Hoffmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No new lines at the end of a file make it more difficult to process the files with scripts as it requires specical attention to get the last line.
Remove to .gitignore files that only contained target directory, which is covered by the root ignore file.