Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrates the MaryTTS Voice add-on to the bnd build.
Some of the MaryTTS packages are split across several JARs which makes it difficult to wrap these as bundles. It also has a lot of dependencies which certainly hasn't improved in newer versions (https://github.com/openhab/openhab2-addons/issues/3953#issuecomment-423659409). 😞
I've also moved the .gitignores for the downloaded libraries to the libs dir so they are automatically moved/deleted on future updates.
log4j-over-slf4j-1.7.21.jar has been removed because it's usage would result in a StackOverflowError. That's probably due to classpath changes causing the ops4j.pax.logging implementations to be picked up:
So it now directly uses that log4j logging implementation instead of slf4j.