Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[marytts] Migrate to bnd build #5354

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Apr 1, 2019

Migrates the MaryTTS Voice add-on to the bnd build.

Some of the MaryTTS packages are split across several JARs which makes it difficult to wrap these as bundles. It also has a lot of dependencies which certainly hasn't improved in newer versions (https://github.com/openhab/openhab2-addons/issues/3953#issuecomment-423659409). 😞

I've also moved the .gitignores for the downloaded libraries to the libs dir so they are automatically moved/deleted on future updates.

log4j-over-slf4j-1.7.21.jar has been removed because it's usage would result in a StackOverflowError. That's probably due to classpath changes causing the ops4j.pax.logging implementations to be picked up:

Caused by: java.lang.StackOverflowError
	at java.util.concurrent.ConcurrentHashMap.get(ConcurrentHashMap.java:936) ~[?:?]
	at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:39) ~[?:?]
	at org.apache.log4j.LogManager.getLogger(LogManager.java:45) ~[?:?]
	at org.slf4j.impl.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:73) ~[?:?]
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:242) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Category.<init>(Category.java:57) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Logger.<init>(Logger.java:37) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:43) ~[?:?]
	at org.apache.log4j.LogManager.getLogger(LogManager.java:45) ~[?:?]
	at org.slf4j.impl.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:73) ~[?:?]
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:242) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Category.<init>(Category.java:57) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Logger.<init>(Logger.java:37) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:43) ~[?:?]
	at org.apache.log4j.LogManager.getLogger(LogManager.java:45) ~[?:?]
	at org.slf4j.impl.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:73) ~[?:?]
	at org.slf4j.LoggerFactory.getLogger(LoggerFactory.java:242) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Category.<init>(Category.java:57) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Logger.<init>(Logger.java:37) ~[6:org.ops4j.pax.logging.pax-logging-api:1.10.1]
	at org.apache.log4j.Log4jLoggerFactory.getLogger(Log4jLoggerFactory.java:43) ~[?:?]
	at org.apache.log4j.LogManager.getLogger(LogManager.java:45) ~[?:?]

So it now directly uses that log4j logging implementation instead of slf4j.

@wborn wborn requested review from kaikreuzer and a team as code owners April 1, 2019 01:00
@Hilbrand Hilbrand added the infrastructure Build system and Karaf related issues and PRs label Apr 1, 2019
@davidgraeff davidgraeff merged commit fc00992 into openhab:master Apr 1, 2019
@wborn wborn deleted the marytts-bnd branch April 1, 2019 20:57
@wborn wborn added this to the 2.5 milestone Apr 14, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants