[Keba] Removed check of firmware version #4987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <[email protected]>
|
FTR, according to https://github.com/openhab/openhab2-addons/issues/3328#issuecomment-376215716, newer firmwares should actually work. |
…ive a response Signed-off-by: Kai Kreuzer <[email protected]>
martinvw
approved these changes
Feb 24, 2019
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* Removed check of firmware version * Make sure that send commands to not block forever if they do not receive a response Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Removed check of firmware version * Make sure that send commands to not block forever if they do not receive a response Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/openhab/openhab2-addons/issues/3328
Note that this PR only removes the check for specific firmware versions (which imho does not make much sense as this info is nowhere used and in general it is better to assume that Keba does not break backward compatibility when releasing newer firmwares).
I cannot say whether or not this binding works correctly with newer firmwares, though, but if there are problems, we should open dedicated issues about them.
Signed-off-by: Kai Kreuzer [email protected]