-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chromecast] Update API lib to v0.10.6 #4965
Conversation
Fixes openhab#4429 Fixes openhab#4800 Signed-off-by: Wouter Born <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Library update looks good. But I am wondering if we should update ChromecastStatusUpdater.updateMediaStatus()
to handle the new LOADING
status.
I think we can handle it like BUFFERING/PLAYING or else like IDLE so it doesn't generate the "unknown" debug logging. WDYT? |
Yes, I think it is similar to BUFFERING/PLAYING. |
Signed-off-by: Wouter Born <[email protected]>
* [chromecast] Update API lib to v0.10.6 Fixes openhab#4429 Fixes openhab#4800 * Handle new LOADING player state Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
* [chromecast] Update API lib to v0.10.6 Fixes openhab#4429 Fixes openhab#4800 * Handle new LOADING player state Signed-off-by: Wouter Born <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Thanks to @vitalidze we can fix some open issues by updating the API lib. 👍
Fixes #4429
Fixes #4800