Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[chromecast] Update API lib to v0.10.6 #4965

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

wborn
Copy link
Member

@wborn wborn commented Feb 22, 2019

Thanks to @vitalidze we can fix some open issues by updating the API lib. 👍

Fixes #4429
Fixes #4800

@wborn wborn requested a review from kaikreuzer as a code owner February 22, 2019 10:30
@wborn wborn requested a review from cweitkamp February 22, 2019 10:38
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wborn
Copy link
Member Author

wborn commented Feb 22, 2019

I think we can handle it like BUFFERING/PLAYING or else like IDLE so it doesn't generate the "unknown" debug logging. WDYT?

@cweitkamp
Copy link
Contributor

Yes, I think it is similar to BUFFERING/PLAYING.

@davidgraeff davidgraeff merged commit ec67a5b into openhab:master Feb 22, 2019
@wborn wborn deleted the update-chromecast-api branch February 22, 2019 14:59
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
* [chromecast] Update API lib to v0.10.6

Fixes openhab#4429
Fixes openhab#4800

* Handle new LOADING player state

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
* [chromecast] Update API lib to v0.10.6

Fixes openhab#4429
Fixes openhab#4800

* Handle new LOADING player state

Signed-off-by: Wouter Born <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants