Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme update #4964

Merged
merged 5 commits into from
Feb 22, 2019
Merged

Readme update #4964

merged 5 commits into from
Feb 22, 2019

Conversation

davidgraeff
Copy link
Member

Update readme, remove ESH reference.

Signed-off-by: davidgraeff [email protected]

Update readme, remove ESH reference.

Signed-off-by: davidgraeff <[email protected]>
@davidgraeff davidgraeff requested a review from a team as a code owner February 22, 2019 10:19
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the nice text. Some suggestions.

Copy link
Contributor

@Confectrician Confectrician left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @davidgraeff,

Looks good so far.
Are the many urls with outh the markdown url syntax on purpose?
See below.

cweitkamp and others added 4 commits February 22, 2019 16:26
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
Co-Authored-By: davidgraeff <[email protected]>
Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Confectrician are you fine with this?

@davidgraeff davidgraeff merged commit fa79869 into master Feb 22, 2019
@davidgraeff davidgraeff deleted the davidgraeff-patch-7 branch February 22, 2019 18:41
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
* Readme update

Update readme, remove ESH reference.

Signed-off-by: davidgraeff <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
* Readme update

Update readme, remove ESH reference.

Signed-off-by: davidgraeff <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants