-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[onkyo] Thing action to send raw eISCP commands #4955
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a thing action to the Onkyo binding to send raw eISCP§ commands to the receiver to support commands that are not built in as channels. I e.g. use this to adjust the volume of the center speaker. Signed-off-by: David Masshardt <[email protected]>
davidgraeff
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wborn
reviewed
Feb 24, 2019
...hab.binding.onkyo/src/main/java/org/openhab/binding/onkyo/internal/handler/OnkyoHandler.java
Outdated
Show resolved
Hide resolved
…nhab/binding/onkyo/internal/handler/OnkyoHandler.java Typo fixed Co-Authored-By: TheNetStriker <[email protected]>
wborn
approved these changes
Feb 25, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the new Thing action!
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* [Onkyo] Thing action to send raw eISCP commands I've added a thing action to the Onkyo binding to send raw eISCP commands to the receiver to support commands that are not built in as channels. I e.g. use this to adjust the volume of the center speaker. Signed-off-by: David Masshardt <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* [Onkyo] Thing action to send raw eISCP commands I've added a thing action to the Onkyo binding to send raw eISCP commands to the receiver to support commands that are not built in as channels. I e.g. use this to adjust the volume of the center speaker. Signed-off-by: David Masshardt <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a thing action to the Onkyo binding to send raw eISCP commands to the receiver to support commands that are not built in as channels. I e.g. use this to adjust the volume of the center speaker.
Here is the link to the forum thread I created for this: https://community.openhab.org/t/onkyo-testers-for-thing-action-to-send-raw-eiscp-commands/68446
Please see the chapter “Rule Actions” in the readme how to use this: https://github.com/TheNetStriker/openhab2-addons/tree/OnkyoThingAction/addons/binding/org.openhab.binding.onkyo
Signed-off-by: David Masshardt [email protected]