Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onkyo] Thing action to send raw eISCP commands #4955

Merged
merged 2 commits into from
Feb 25, 2019
Merged

[onkyo] Thing action to send raw eISCP commands #4955

merged 2 commits into from
Feb 25, 2019

Conversation

TheNetStriker
Copy link
Contributor

I've added a thing action to the Onkyo binding to send raw eISCP commands to the receiver to support commands that are not built in as channels. I e.g. use this to adjust the volume of the center speaker.

Here is the link to the forum thread I created for this: https://community.openhab.org/t/onkyo-testers-for-thing-action-to-send-raw-eiscp-commands/68446

Please see the chapter “Rule Actions” in the readme how to use this: https://github.com/TheNetStriker/openhab2-addons/tree/OnkyoThingAction/addons/binding/org.openhab.binding.onkyo

Signed-off-by: David Masshardt [email protected]

I've added a thing action to the Onkyo binding to send raw eISCP§
commands to the receiver to support commands that are not built in as
channels. I e.g. use this to adjust the volume of the center speaker.

Signed-off-by: David Masshardt <[email protected]>
Copy link
Member

@davidgraeff davidgraeff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wborn wborn added rebuild Triggers Jenkins PR build enhancement An enhancement or new feature for an existing add-on and removed rebuild Triggers Jenkins PR build labels Feb 23, 2019
…nhab/binding/onkyo/internal/handler/OnkyoHandler.java


Typo fixed

Co-Authored-By: TheNetStriker <[email protected]>
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new Thing action!

@wborn wborn merged commit d3126bc into openhab:master Feb 25, 2019
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
* [Onkyo] Thing action to send raw eISCP commands

I've added a thing action to the Onkyo binding to send raw eISCP
commands to the receiver to support commands that are not built in as
channels. I e.g. use this to adjust the volume of the center speaker.

Signed-off-by: David Masshardt <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
* [Onkyo] Thing action to send raw eISCP commands

I've added a thing action to the Onkyo binding to send raw eISCP
commands to the receiver to support commands that are not built in as
channels. I e.g. use this to adjust the volume of the center speaker.

Signed-off-by: David Masshardt <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn changed the title [Onkyo] Thing action to send raw eISCP commands [onkyo] Thing action to send raw eISCP commands Dec 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants