[harmonyhub] Websocket implementation #4926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: digitaldan <[email protected]>
Signed-off-by: digitaldan <[email protected]>
…fixes button press Signed-off-by: digitaldan <[email protected]>
Signed-off-by: digitaldan <[email protected]>
Signed-off-by: digitaldan <[email protected]>
Signed-off-by: digitaldan <[email protected]>
wborn
reviewed
Feb 18, 2019
...monyhub/src/main/java/org/openhab/binding/harmonyhub/internal/handler/HarmonyHubHandler.java
Outdated
Show resolved
Hide resolved
wborn
reviewed
Feb 18, 2019
wborn
reviewed
Feb 18, 2019
addons/binding/org.openhab.binding.harmonyhub/META-INF/MANIFEST.MF
Outdated
Show resolved
Hide resolved
wborn
reviewed
Feb 18, 2019
...monyhub/src/main/java/org/openhab/binding/harmonyhub/internal/handler/HarmonyHubHandler.java
Outdated
Show resolved
Hide resolved
…es, updated client to version 1.0, updated notice file of change of libraries. Signed-off-by: digitaldan <[email protected]>
|
@wborn thanks for the review! All changes made and committed. |
Signed-off-by: Wouter Born <[email protected]>
wborn
approved these changes
Feb 18, 2019
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/harmony-hub-binding-stopped-working/65986/12 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/icloud-binding-refresh-device-data-failed-again/69457/34 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/preparation-for-2-5m2/75738/3 |
|
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/preparation-for-2-5m2/75738/1 |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
* Changed to using new websocket based library * Updating client lib, small changes to stability and timeouts * Update current activity when connected, update to latest client lib, fixes button press * Adding update jar * Update to latest client, fix merge issue * Removed dead/commented code, reduced log level, cleanup classpath files, updated client to version 1.0, updated notice file of change of libraries. * Remove empty line before closing brace Signed-off-by: Dan Cunningham <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
* Changed to using new websocket based library * Updating client lib, small changes to stability and timeouts * Update current activity when connected, update to latest client lib, fixes button press * Adding update jar * Update to latest client, fix merge issue * Removed dead/commented code, reduced log level, cleanup classpath files, updated client to version 1.0, updated notice file of change of libraries. * Remove empty line before closing brace Signed-off-by: Dan Cunningham <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches from using XMPP to JSON over Websockets. This was trigger by Logitech disabling XMPP access back in December. While they have since re-enabled XMPP as an option in their mobile app, WebSockets provide many advantages:
Initial tests with users show this is a drop in replacement and will not require any changes to items or files.
Fixes #4411
Also see https://community.openhab.org/t/logitech-harmony-hub-binding-4-15-206-firmware-broke-local-api-connection/60090
@wborn, anything to add?