removed UIs as they are now at openhab-webui #4923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Kreuzer <[email protected]>
kaikreuzer
requested review from
htreu,
kubawolanin,
lolodomo,
peuter,
vlad-ivanov-name and
a team
as code owners
peuter
approved these changes
Feb 18, 2019
wborn
reviewed
Feb 18, 2019
There was a problem hiding this comment.
Can you also remove all /addons/ui dirs from the CODEOWNERS file?
|
I'll change the codeowners in a follow up |
|
We still have a couple of UI issues in the issue tracker. Can you use your powers to transfer these to the webui repo @kaikreuzer ? These are the UI issues I found:
|
|
@wborn Done! |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
Signed-off-by: Kai Kreuzer <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UIs had only been moved temporarily here, but are now located at https://github.com/openhab/openhab-webui.
This should speed up the addons build again and especially solve the OOM issues that npm causes, so that we can reactivate SAT check and unit test execution.
Signed-off-by: Kai Kreuzer [email protected]