Update NetworkUtils.java #4898
Merged
Update NetworkUtils.java #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added Eli Fulkerson ARP Ping tool detection. 2. Replaced Thomas Habets ARP Ping tool detection RegExp with simple "contains" statement. 3. Added command line to nativeARPPing subrooting for Eli Fulkerson ARP Ping tool.
davidgraeff
requested changes
Feb 14, 2019
1. Added Eli Fulkerson ARP Ping tool detection. 2. Replaced Thomas Habets ARP Ping tool detection RegExp with simple "contains" statement. 3. Added command line to nativeARPPing subrooting for Eli Fulkerson ARP Ping tool. Signed-off-by: Konstantin Panchenko <[email protected]>
1. Added Eli Fulkerson ARP Ping tool detection. 2. Added command line to nativeARPPing subrooting for Eli Fulkerson ARP Ping tool. 3. Reverted Thomas Habets detection back to original code. Signed-off-by: Konstantin Panchenko <[email protected]>
I did test it but I'll create a new one anyway, probably Thomas changed his help output. |
davidgraeff
approved these changes
Feb 14, 2019
|
Thanks! |
|
Just one note: I think you do not mention where to get that tool from in the readme file. Maybe you could make a PR for that as well? Binding documentations are allowed to link to external commercial/non-commercial products. Cheers |
Pshatsillo
pushed a commit
to Pshatsillo/openhab-addons
that referenced
this pull request
Jun 19, 2019
Added Eli Fulkerson ARP Ping tool detection. Added command line to nativeARPPing subrooting for Eli Fulkerson ARP Ping tool. Signed-off-by: Konstantin Panchenko <[email protected]> Signed-off-by: Pshatsillo <[email protected]>
ne0h
pushed a commit
to ne0h/openhab-addons
that referenced
this pull request
Sep 15, 2019
Added Eli Fulkerson ARP Ping tool detection. Added command line to nativeARPPing subrooting for Eli Fulkerson ARP Ping tool. Signed-off-by: Konstantin Panchenko <[email protected]> Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[network] Added support for Eli Fulkerson ARP Ping Tool
Support for arp-ping.exe tool for Windows from Eli Fulkerson:
https://www.elifulkerson.com/projects/arp-ping.php
Signed-off-by: Konstantin Panchenko [email protected]