Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tradfri] Aligned rounding for brightness values #4895

Merged
merged 1 commit into from
Feb 17, 2019

Conversation

cweitkamp
Copy link
Contributor

  • Aligned rounding for brigthness values

Sending 1% from OH to TRADFRI results in 2% on next update

See https://community.openhab.org/t/off-by-1-value-in-events-with-tradfri-dimmer-levels/67568

Signed-off-by: Christoph Weitkamp [email protected]

Signed-off-by: Christoph Weitkamp <[email protected]>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/off-by-1-value-in-events-with-tradfri-dimmer-levels/67568/7

@wborn wborn changed the title [tradfri] Aligned rounding for brigthness values [tradfri] Aligned rounding for brightness values Feb 17, 2019
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the alignment!

@wborn wborn merged commit 1c618e9 into openhab:master Feb 17, 2019
@cweitkamp cweitkamp deleted the bugfix-tradfri-brightness branch February 17, 2019 10:14
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
Signed-off-by: Christoph Weitkamp <[email protected]>
Signed-off-by: Maximilian Hess <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants