Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[yeelight] Fix typo in readme and add example for switch on color cha… #4887

Merged
merged 2 commits into from
Feb 16, 2019

Conversation

claell
Copy link

@claell claell commented Feb 12, 2019

…nnel

Signed-off-by: Claudius Ellsel [email protected] (github: claell)

@goodfore
Copy link

Oh, while you are at it, can you please also add the duration in the Things Configuration? I forgot to add that in.
Thanks,
Joe

Signed-off-by: Claudius Ellsel <[email protected]> (github: claell)
@claell
Copy link
Author

claell commented Feb 12, 2019

I had in mind that this was lacking, but was too lazy to go ahead, look into that and write it. Turned out it were just a few changes, so integrated now!

@goodfore
Copy link

Thank you!

Copy link
Contributor

@cweitkamp cweitkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@cweitkamp cweitkamp merged commit f461465 into master Feb 16, 2019
@cweitkamp cweitkamp deleted the claell-patch-1 branch February 16, 2019 08:02
@wborn wborn added this to the 2.5 milestone Feb 28, 2019
Pshatsillo pushed a commit to Pshatsillo/openhab-addons that referenced this pull request Jun 19, 2019
openhab#4887)

* Fix typo in readme and add example for switch on color channel 
* Add duration parameter information

Signed-off-by: Claudius Ellsel <[email protected]> (github: claell)
Signed-off-by: Pshatsillo <[email protected]>
ne0h pushed a commit to ne0h/openhab-addons that referenced this pull request Sep 15, 2019
openhab#4887)

* Fix typo in readme and add example for switch on color channel 
* Add duration parameter information

Signed-off-by: Claudius Ellsel <[email protected]> (github: claell)
Signed-off-by: Maximilian Hess <[email protected]>
@wborn wborn removed this from the 2.5 milestone Dec 8, 2019
@wborn wborn added this to the 2.5 milestone Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants